Title: [240967] trunk/Source/WebInspectorUI
- Revision
- 240967
- Author
- drou...@apple.com
- Date
- 2019-02-04 23:48:10 -0800 (Mon, 04 Feb 2019)
Log Message
Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'classes.includes')
https://bugs.webkit.org/show_bug.cgi?id=194280
<rdar://problem/47811159>
Reviewed by Matt Baker.
* UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
(WI.GeneralStyleDetailsSidebarPanel.prototype._populateClassToggles):
Add a fallback value in case the `class` attribute isn't specified for the selected node.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (240966 => 240967)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-02-05 06:51:29 UTC (rev 240966)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-02-05 07:48:10 UTC (rev 240967)
@@ -1,5 +1,17 @@
2019-02-04 Devin Rousso <drou...@apple.com>
+ Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'classes.includes')
+ https://bugs.webkit.org/show_bug.cgi?id=194280
+ <rdar://problem/47811159>
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
+ (WI.GeneralStyleDetailsSidebarPanel.prototype._populateClassToggles):
+ Add a fallback value in case the `class` attribute isn't specified for the selected node.
+
+2019-02-04 Devin Rousso <drou...@apple.com>
+
Web Inspector: Resources: missing resource data for document on reload
https://bugs.webkit.org/show_bug.cgi?id=194243
<rdar://problem/47559021>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js (240966 => 240967)
--- trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js 2019-02-05 06:51:29 UTC (rev 240966)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js 2019-02-05 07:48:10 UTC (rev 240967)
@@ -359,7 +359,7 @@
while (this._classListContainer.children.length > 1)
this._classListContainer.children[1].remove();
- let classes = this.domNode.getAttribute("class");
+ let classes = this.domNode.getAttribute("class") || [];
let classToggledMap = this.domNode[WI.GeneralStyleDetailsSidebarPanel.ToggledClassesSymbol];
if (!classToggledMap)
classToggledMap = this.domNode[WI.GeneralStyleDetailsSidebarPanel.ToggledClassesSymbol] = new Map;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
