Title: [240970] trunk/Source/WebInspectorUI
- Revision
- 240970
- Author
- [email protected]
- Date
- 2019-02-05 03:18:03 -0800 (Tue, 05 Feb 2019)
Log Message
Web Inspector: Styles: remove harmless "property was unlocked" asserts
https://bugs.webkit.org/show_bug.cgi?id=194262
Reviewed by Matt Baker.
* UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype.remove):
(WI.SpreadsheetStyleProperty.prototype.update):
(WI.SpreadsheetStyleProperty.prototype._handleNameChange):
(WI.SpreadsheetStyleProperty.prototype._handleValueChange):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (240969 => 240970)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-02-05 10:49:12 UTC (rev 240969)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-02-05 11:18:03 UTC (rev 240970)
@@ -1,3 +1,16 @@
+2019-02-05 Nikita Vasilyev <[email protected]>
+
+ Web Inspector: Styles: remove harmless "property was unlocked" asserts
+ https://bugs.webkit.org/show_bug.cgi?id=194262
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Views/SpreadsheetStyleProperty.js:
+ (WI.SpreadsheetStyleProperty.prototype.remove):
+ (WI.SpreadsheetStyleProperty.prototype.update):
+ (WI.SpreadsheetStyleProperty.prototype._handleNameChange):
+ (WI.SpreadsheetStyleProperty.prototype._handleValueChange):
+
2019-02-04 Devin Rousso <[email protected]>
Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'classes.includes')
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js (240969 => 240970)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js 2019-02-05 10:49:12 UTC (rev 240969)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js 2019-02-05 11:18:03 UTC (rev 240970)
@@ -131,7 +131,6 @@
remove(replacement = null)
{
- console.assert(this._property.ownerStyle.locked, `Removed property was unlocked (${this._property.name})`);
this.element.remove();
if (replacement)
@@ -156,7 +155,6 @@
this._checkboxElement.checked = this._property.enabled;
this._checkboxElement.tabIndex = -1;
this._checkboxElement.addEventListener("click", (event) => {
- console.assert(this._property.ownerStyle.locked, `Toggled property was unlocked (${this._property.name})`);
event.stopPropagation();
let disabled = !this._checkboxElement.checked;
this._property.commentOut(disabled);
@@ -676,15 +674,11 @@
_handleNameChange()
{
- console.assert(this._property.ownerStyle.locked, `Modified property was unlocked (${this._property.name})`);
-
this._property.name = this._nameElement.textContent.trim();
}
_handleValueChange()
{
- console.assert(this._property.ownerStyle.locked, `Modified property was unlocked (${this._property.name})`);
-
this._property.rawValue = this._valueElement.textContent.trim();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
