Title: [240989] trunk/LayoutTests
- Revision
- 240989
- Author
- [email protected]
- Date
- 2019-02-05 12:35:10 -0800 (Tue, 05 Feb 2019)
Log Message
Web Inspector: Fix modify-css-property-race.html test failures
https://bugs.webkit.org/show_bug.cgi?id=194282
Reviewed by Matt Baker.
Fix test failures introduced by r240946 by providing a message for expectGreaterThan assert,
so it doesn't log the actual values.
* inspector/css/modify-css-property-race-expected.txt:
* inspector/css/modify-css-property-race.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (240988 => 240989)
--- trunk/LayoutTests/ChangeLog 2019-02-05 20:30:54 UTC (rev 240988)
+++ trunk/LayoutTests/ChangeLog 2019-02-05 20:35:10 UTC (rev 240989)
@@ -1,3 +1,16 @@
+2019-02-05 Nikita Vasilyev <[email protected]>
+
+ Web Inspector: Fix modify-css-property-race.html test failures
+ https://bugs.webkit.org/show_bug.cgi?id=194282
+
+ Reviewed by Matt Baker.
+
+ Fix test failures introduced by r240946 by providing a message for expectGreaterThan assert,
+ so it doesn't log the actual values.
+
+ * inspector/css/modify-css-property-race-expected.txt:
+ * inspector/css/modify-css-property-race.html:
+
2019-02-05 Andy VanWagoner <[email protected]>
REGRESSION(r238848): ICU upgrade broke jsc-layout-tests.yaml/js/script-tests/intl-numberformat.js.layout
Modified: trunk/LayoutTests/inspector/css/modify-css-property-race-expected.txt (240988 => 240989)
--- trunk/LayoutTests/inspector/css/modify-css-property-race-expected.txt 2019-02-05 20:30:54 UTC (rev 240988)
+++ trunk/LayoutTests/inspector/css/modify-css-property-race-expected.txt 2019-02-05 20:35:10 UTC (rev 240989)
@@ -3,9 +3,9 @@
== Running test suite: ModifyCSSProperty
-- Running test case: ModifyCSSPropertyRace.ChangeInlineStyle
-PASS: expectGreaterThan(43, 42)
-PASS: expectGreaterThan(43, 42)
-PASS: Value updated to "10px".
+PASS: Height should be greater than 42px.
+PASS: Height should be greater than 42px.
+PASS: Height should be 10px.
PASS: CSSStyleDeclaration text should update.
-PASS: expectGreaterThanOrEqual(10, 10)
+PASS: Height should be greater or equal 10px.
Modified: trunk/LayoutTests/inspector/css/modify-css-property-race.html (240988 => 240989)
--- trunk/LayoutTests/inspector/css/modify-css-property-race.html 2019-02-05 20:30:54 UTC (rev 240988)
+++ trunk/LayoutTests/inspector/css/modify-css-property-race.html 2019-02-05 20:35:10 UTC (rev 240989)
@@ -66,17 +66,17 @@
function styleDecorationUpdated(event) {
if (!updateCount) {
let valueNumber = parseInt(getProperty("height").rawValue);
- InspectorTest.expectGreaterThan(valueNumber, 42);
+ InspectorTest.expectGreaterThan(valueNumber, 42, "Height should be greater than 42px.");
} else if (updateCount === 1) {
let valueNumber = parseInt(getProperty("height").rawValue);
- InspectorTest.expectGreaterThan(valueNumber, 42);
+ InspectorTest.expectGreaterThan(valueNumber, 42, "Height should be greater than 42px.");
getProperty("height").rawValue = "10px";
} else if (updateCount === 2) {
- InspectorTest.expectEqual(getProperty("height").rawValue, "10px", `Value updated to "10px".`);
+ InspectorTest.expectEqual(getProperty("height").rawValue, "10px", "Height should be 10px.");
InspectorTest.expectEqual(getInlineStyleDeclaration().text, "height: 10px;", "CSSStyleDeclaration text should update.");
} else {
let valueNumber = parseInt(getProperty("height").rawValue);
- InspectorTest.expectGreaterThanOrEqual(valueNumber, 10);
+ InspectorTest.expectGreaterThanOrEqual(valueNumber, 10, "Height should be greater or equal 10px.");
InspectorTest.evaluateInPage("stopExpanding()");
WI.CSSStyleDeclaration.removeEventListener(WI.CSSStyleDeclaration.Event.PropertiesChanged, styleDecorationUpdated);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
