Title: [240997] trunk/Source/WebInspectorUI
- Revision
- 240997
- Author
- [email protected]
- Date
- 2019-02-05 15:33:05 -0800 (Tue, 05 Feb 2019)
Log Message
Web Inspector: REGRESSION (r240947): Resources tab: can't select main frame after refreshing page
https://bugs.webkit.org/show_bug.cgi?id=194254
<rdar://problem/47805023>
Reviewed by Devin Rousso.
* UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype.selectionControllerSelectionDidChange):
TreeOutline should always call the TreeElement `select` and `deselect`
methods while processing selection changes. Having notifications
suppressed by `this._suppressNextSelectionDidChangeEvent` should only
affect the dispatching of TreeOutline events.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (240996 => 240997)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-02-05 23:17:14 UTC (rev 240996)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-02-05 23:33:05 UTC (rev 240997)
@@ -1,3 +1,18 @@
+2019-02-05 Matt Baker <[email protected]>
+
+ Web Inspector: REGRESSION (r240947): Resources tab: can't select main frame after refreshing page
+ https://bugs.webkit.org/show_bug.cgi?id=194254
+ <rdar://problem/47805023>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/TreeOutline.js:
+ (WI.TreeOutline.prototype.selectionControllerSelectionDidChange):
+ TreeOutline should always call the TreeElement `select` and `deselect`
+ methods while processing selection changes. Having notifications
+ suppressed by `this._suppressNextSelectionDidChangeEvent` should only
+ affect the dispatching of TreeOutline events.
+
2019-02-05 Nikita Vasilyev <[email protected]>
Web Inspector: Styles: remove harmless "property was unlocked" asserts
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (240996 => 240997)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2019-02-05 23:17:14 UTC (rev 240996)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2019-02-05 23:33:05 UTC (rev 240997)
@@ -812,8 +812,7 @@
if (treeElement) {
if (treeElement.listItemElement)
treeElement.listItemElement.classList.remove("selected");
- if (!this._suppressNextSelectionDidChangeEvent)
- treeElement.deselect();
+ treeElement.deselect();
}
}
@@ -823,8 +822,8 @@
if (treeElement) {
if (treeElement.listItemElement)
treeElement.listItemElement.classList.add("selected");
- if (!this._suppressNextSelectionDidChangeEvent)
- treeElement.select();
+ const omitFocus = true;
+ treeElement.select(omitFocus);
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
