Title: [241009] trunk
- Revision
- 241009
- Author
- [email protected]
- Date
- 2019-02-05 20:26:54 -0800 (Tue, 05 Feb 2019)
Log Message
Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
https://bugs.webkit.org/show_bug.cgi?id=194324
Reviewed by Andy Estes.
Tools:
Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
part of the name is already implicit, since this is in testing code in TestOptions.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::generateContextConfiguration const):
(WTR::updateTestOptionsFromTestHeader):
* WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):
LayoutTests:
* fast/events/touch/ios/show-modal-alert-during-touch-start.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (241008 => 241009)
--- trunk/LayoutTests/ChangeLog 2019-02-06 02:10:50 UTC (rev 241008)
+++ trunk/LayoutTests/ChangeLog 2019-02-06 04:26:54 UTC (rev 241009)
@@ -1,3 +1,12 @@
+2019-02-05 Wenson Hsieh <[email protected]>
+
+ Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
+ https://bugs.webkit.org/show_bug.cgi?id=194324
+
+ Reviewed by Andy Estes.
+
+ * fast/events/touch/ios/show-modal-alert-during-touch-start.html:
+
2019-02-05 Nikita Vasilyev <[email protected]>
Web Inspector: Fix modify-css-property-race.html test failures
Modified: trunk/LayoutTests/fast/events/touch/ios/show-modal-alert-during-touch-start.html (241008 => 241009)
--- trunk/LayoutTests/fast/events/touch/ios/show-modal-alert-during-touch-start.html 2019-02-06 02:10:50 UTC (rev 241008)
+++ trunk/LayoutTests/fast/events/touch/ios/show-modal-alert-during-touch-start.html 2019-02-06 04:26:54 UTC (rev 241009)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true, ignoreSynchronousMessagingTimeoutsForTesting=true ] -->
+<!DOCTYPE html> <!-- webkit-test-runner [ useFlexibleViewport=true, ignoreSynchronousMessagingTimeouts=true ] -->
<html>
<head>
<meta name="viewport" content="width=device-width, initial-scale=1, user-scalable=no">
Modified: trunk/Tools/ChangeLog (241008 => 241009)
--- trunk/Tools/ChangeLog 2019-02-06 02:10:50 UTC (rev 241008)
+++ trunk/Tools/ChangeLog 2019-02-06 04:26:54 UTC (rev 241009)
@@ -1,3 +1,19 @@
+2019-02-05 Wenson Hsieh <[email protected]>
+
+ Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
+ https://bugs.webkit.org/show_bug.cgi?id=194324
+
+ Reviewed by Andy Estes.
+
+ Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
+ part of the name is already implicit, since this is in testing code in TestOptions.
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::generateContextConfiguration const):
+ (WTR::updateTestOptionsFromTestHeader):
+ * WebKitTestRunner/TestOptions.h:
+ (WTR::TestOptions::hasSameInitializationOptions const):
+
2019-02-05 Aakash Jain <[email protected]>
[ews-build] Allow * as platform for builders and workers
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (241008 => 241009)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2019-02-06 02:10:50 UTC (rev 241008)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2019-02-06 04:26:54 UTC (rev 241009)
@@ -458,7 +458,7 @@
auto configuration = adoptWK(WKContextConfigurationCreate());
WKContextConfigurationSetInjectedBundlePath(configuration.get(), injectedBundlePath());
WKContextConfigurationSetFullySynchronousModeIsAllowedForTesting(configuration.get(), true);
- WKContextConfigurationSetIgnoreSynchronousMessagingTimeoutsForTesting(configuration.get(), options.ignoreSynchronousMessagingTimeoutsForTesting);
+ WKContextConfigurationSetIgnoreSynchronousMessagingTimeoutsForTesting(configuration.get(), options.ignoreSynchronousMessagingTimeouts);
if (const char* dumpRenderTreeTemp = libraryPathForTesting()) {
String temporaryFolder = String::fromUTF8(dumpRenderTreeTemp);
@@ -1286,8 +1286,8 @@
testOptions.enableUndoManagerAPI = parseBooleanTestHeaderValue(value);
else if (key == "contentInset.top")
testOptions.contentInsetTop = std::stod(value);
- else if (key == "ignoreSynchronousMessagingTimeoutsForTesting")
- testOptions.ignoreSynchronousMessagingTimeoutsForTesting = parseBooleanTestHeaderValue(value);
+ else if (key == "ignoreSynchronousMessagingTimeouts")
+ testOptions.ignoreSynchronousMessagingTimeouts = parseBooleanTestHeaderValue(value);
pairStart = pairEnd + 1;
}
}
Modified: trunk/Tools/WebKitTestRunner/TestOptions.h (241008 => 241009)
--- trunk/Tools/WebKitTestRunner/TestOptions.h 2019-02-06 02:10:50 UTC (rev 241008)
+++ trunk/Tools/WebKitTestRunner/TestOptions.h 2019-02-06 04:26:54 UTC (rev 241009)
@@ -68,7 +68,7 @@
bool enableEditableImages { false };
bool editable { false };
bool enableUndoManagerAPI { false };
- bool ignoreSynchronousMessagingTimeoutsForTesting { false };
+ bool ignoreSynchronousMessagingTimeouts { false };
double contentInsetTop { 0 };
@@ -118,7 +118,7 @@
|| editable != options.editable
|| enableUndoManagerAPI != options.enableUndoManagerAPI
|| contentInsetTop != options.contentInsetTop
- || ignoreSynchronousMessagingTimeoutsForTesting != options.ignoreSynchronousMessagingTimeoutsForTesting)
+ || ignoreSynchronousMessagingTimeouts != options.ignoreSynchronousMessagingTimeouts)
return false;
if (experimentalFeatures != options.experimentalFeatures)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
