Title: [241065] branches/safari-607-branch/Source/WebKit
- Revision
- 241065
- Author
- alanc...@apple.com
- Date
- 2019-02-06 14:16:42 -0800 (Wed, 06 Feb 2019)
Log Message
Cherry-pick r240702. rdar://problem/47774503
iOS: Nullptr crash in WebPage::getPositionInformation dereferencing an input element for data list
https://bugs.webkit.org/show_bug.cgi?id=193996
Reviewed by Wenson Hsieh.
Added a missing nullptr check.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-607-branch/Source/WebKit/ChangeLog (241064 => 241065)
--- branches/safari-607-branch/Source/WebKit/ChangeLog 2019-02-06 22:16:39 UTC (rev 241064)
+++ branches/safari-607-branch/Source/WebKit/ChangeLog 2019-02-06 22:16:42 UTC (rev 241065)
@@ -1,5 +1,34 @@
2019-02-05 Alan Coon <alanc...@apple.com>
+ Cherry-pick r240702. rdar://problem/47774503
+
+ iOS: Nullptr crash in WebPage::getPositionInformation dereferencing an input element for data list
+ https://bugs.webkit.org/show_bug.cgi?id=193996
+
+ Reviewed by Wenson Hsieh.
+
+ Added a missing nullptr check.
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::getPositionInformation):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-01-29 Ryosuke Niwa <rn...@webkit.org>
+
+ iOS: Nullptr crash in WebPage::getPositionInformation dereferencing an input element for data list
+ https://bugs.webkit.org/show_bug.cgi?id=193996
+
+ Reviewed by Wenson Hsieh.
+
+ Added a missing nullptr check.
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::getPositionInformation):
+
+2019-02-05 Alan Coon <alanc...@apple.com>
+
Cherry-pick r240675. rdar://problem/47776350
Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
Modified: branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (241064 => 241065)
--- branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2019-02-06 22:16:39 UTC (rev 241064)
+++ branches/safari-607-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2019-02-06 22:16:42 UTC (rev 241065)
@@ -2247,7 +2247,7 @@
// Prevent the callout bar from showing when tapping on the datalist button.
#if ENABLE(DATALIST_ELEMENT)
- if (is<HTMLInputElement>(*hitNode)) {
+ if (is<HTMLInputElement>(hitNode)) {
const HTMLInputElement& input = downcast<HTMLInputElement>(*hitNode);
if (input.list()) {
HitTestResult result = m_page->mainFrame().eventHandler().hitTestResultAtPoint(request.point, HitTestRequest::ReadOnly | HitTestRequest::Active);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
