Title: [241086] branches/safari-607-branch/Source/WebInspectorUI
- Revision
- 241086
- Author
- alanc...@apple.com
- Date
- 2019-02-06 14:17:43 -0800 (Wed, 06 Feb 2019)
Log Message
Cherry-pick r240997. rdar://problem/47838594
Web Inspector: REGRESSION (r240947): Resources tab: can't select main frame after refreshing page
https://bugs.webkit.org/show_bug.cgi?id=194254
<rdar://problem/47805023>
Reviewed by Devin Rousso.
* UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype.selectionControllerSelectionDidChange):
TreeOutline should always call the TreeElement `select` and `deselect`
methods while processing selection changes. Having notifications
suppressed by `this._suppressNextSelectionDidChangeEvent` should only
affect the dispatching of TreeOutline events.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-607-branch/Source/WebInspectorUI/ChangeLog (241085 => 241086)
--- branches/safari-607-branch/Source/WebInspectorUI/ChangeLog 2019-02-06 22:17:41 UTC (rev 241085)
+++ branches/safari-607-branch/Source/WebInspectorUI/ChangeLog 2019-02-06 22:17:43 UTC (rev 241086)
@@ -1,5 +1,40 @@
2019-02-05 Alan Coon <alanc...@apple.com>
+ Cherry-pick r240997. rdar://problem/47838594
+
+ Web Inspector: REGRESSION (r240947): Resources tab: can't select main frame after refreshing page
+ https://bugs.webkit.org/show_bug.cgi?id=194254
+ <rdar://problem/47805023>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/TreeOutline.js:
+ (WI.TreeOutline.prototype.selectionControllerSelectionDidChange):
+ TreeOutline should always call the TreeElement `select` and `deselect`
+ methods while processing selection changes. Having notifications
+ suppressed by `this._suppressNextSelectionDidChangeEvent` should only
+ affect the dispatching of TreeOutline events.
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-02-05 Matt Baker <mattba...@apple.com>
+
+ Web Inspector: REGRESSION (r240947): Resources tab: can't select main frame after refreshing page
+ https://bugs.webkit.org/show_bug.cgi?id=194254
+ <rdar://problem/47805023>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/TreeOutline.js:
+ (WI.TreeOutline.prototype.selectionControllerSelectionDidChange):
+ TreeOutline should always call the TreeElement `select` and `deselect`
+ methods while processing selection changes. Having notifications
+ suppressed by `this._suppressNextSelectionDidChangeEvent` should only
+ affect the dispatching of TreeOutline events.
+
+2019-02-05 Alan Coon <alanc...@apple.com>
+
Cherry-pick r240947. rdar://problem/47830605
Web Inspector: REGRESSION: clicking a selected call frame doesn't re-scroll
Modified: branches/safari-607-branch/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (241085 => 241086)
--- branches/safari-607-branch/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2019-02-06 22:17:41 UTC (rev 241085)
+++ branches/safari-607-branch/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2019-02-06 22:17:43 UTC (rev 241086)
@@ -812,8 +812,7 @@
if (treeElement) {
if (treeElement.listItemElement)
treeElement.listItemElement.classList.remove("selected");
- if (!this._suppressNextSelectionDidChangeEvent)
- treeElement.deselect();
+ treeElement.deselect();
}
}
@@ -823,8 +822,8 @@
if (treeElement) {
if (treeElement.listItemElement)
treeElement.listItemElement.classList.add("selected");
- if (!this._suppressNextSelectionDidChangeEvent)
- treeElement.select();
+ const omitFocus = true;
+ treeElement.select(omitFocus);
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
