- Revision
- 241103
- Author
- [email protected]
- Date
- 2019-02-06 14:54:54 -0800 (Wed, 06 Feb 2019)
Log Message
Really enable the automatic checking and regenerations of .xcfilelists during builds
https://bugs.webkit.org/show_bug.cgi?id=194357
<rdar://problem/47861231>
Reviewed by Chris Dumez.
Bug 194124 was supposed to enable the automatic checking and
regenerating of .xcfilelist files during the build. While related
changes were included in that patch, the change to actually enable the
operation somehow was omitted. This patch actually enables the
operation. The check-xcfilelist.sh scripts now check
WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
from the checking.
Source/_javascript_Core:
* Scripts/check-xcfilelists.sh:
Source/WebCore:
No new tests since there should be no observable behavior difference.
* Scripts/check-xcfilelists.sh:
Source/WebKit:
* Scripts/check-xcfilelists.sh:
Tools:
* DumpRenderTree/Scripts/check-xcfilelists.sh:
* WebKitTestRunner/Scripts/check-xcfilelists.sh:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (241102 => 241103)
--- trunk/Source/_javascript_Core/ChangeLog 2019-02-06 22:18:36 UTC (rev 241102)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-02-06 22:54:54 UTC (rev 241103)
@@ -1,3 +1,21 @@
+2019-02-06 Keith Rollin <[email protected]>
+
+ Really enable the automatic checking and regenerations of .xcfilelists during builds
+ https://bugs.webkit.org/show_bug.cgi?id=194357
+ <rdar://problem/47861231>
+
+ Reviewed by Chris Dumez.
+
+ Bug 194124 was supposed to enable the automatic checking and
+ regenerating of .xcfilelist files during the build. While related
+ changes were included in that patch, the change to actually enable the
+ operation somehow was omitted. This patch actually enables the
+ operation. The check-xcfilelist.sh scripts now check
+ WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
+ from the checking.
+
+ * Scripts/check-xcfilelists.sh:
+
2019-02-06 Yusuke Suzuki <[email protected]>
[JSC] Unify indirectEvalExecutableSpace and directEvalExecutableSpace
Modified: trunk/Source/_javascript_Core/Scripts/check-xcfilelists.sh (241102 => 241103)
--- trunk/Source/_javascript_Core/Scripts/check-xcfilelists.sh 2019-02-06 22:18:36 UTC (rev 241102)
+++ trunk/Source/_javascript_Core/Scripts/check-xcfilelists.sh 2019-02-06 22:54:54 UTC (rev 241103)
@@ -1,6 +1,6 @@
#!/bin/sh
-[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; }
+[ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
[ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
[ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
Modified: trunk/Source/WebCore/ChangeLog (241102 => 241103)
--- trunk/Source/WebCore/ChangeLog 2019-02-06 22:18:36 UTC (rev 241102)
+++ trunk/Source/WebCore/ChangeLog 2019-02-06 22:54:54 UTC (rev 241103)
@@ -1,3 +1,23 @@
+2019-02-06 Keith Rollin <[email protected]>
+
+ Really enable the automatic checking and regenerations of .xcfilelists during builds
+ https://bugs.webkit.org/show_bug.cgi?id=194357
+ <rdar://problem/47861231>
+
+ Reviewed by Chris Dumez.
+
+ Bug 194124 was supposed to enable the automatic checking and
+ regenerating of .xcfilelist files during the build. While related
+ changes were included in that patch, the change to actually enable the
+ operation somehow was omitted. This patch actually enables the
+ operation. The check-xcfilelist.sh scripts now check
+ WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
+ from the checking.
+
+ No new tests since there should be no observable behavior difference.
+
+ * Scripts/check-xcfilelists.sh:
+
2019-02-06 John Wilander <[email protected]>
Forward Ad Click Attribution data from HTMLAnchorElement::handleClick() to WebKit::NavigationActionData
Modified: trunk/Source/WebCore/Scripts/check-xcfilelists.sh (241102 => 241103)
--- trunk/Source/WebCore/Scripts/check-xcfilelists.sh 2019-02-06 22:18:36 UTC (rev 241102)
+++ trunk/Source/WebCore/Scripts/check-xcfilelists.sh 2019-02-06 22:54:54 UTC (rev 241103)
@@ -1,6 +1,6 @@
#!/bin/sh
-[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; }
+[ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
[ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
[ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
Modified: trunk/Source/WebKit/ChangeLog (241102 => 241103)
--- trunk/Source/WebKit/ChangeLog 2019-02-06 22:18:36 UTC (rev 241102)
+++ trunk/Source/WebKit/ChangeLog 2019-02-06 22:54:54 UTC (rev 241103)
@@ -1,3 +1,21 @@
+2019-02-06 Keith Rollin <[email protected]>
+
+ Really enable the automatic checking and regenerations of .xcfilelists during builds
+ https://bugs.webkit.org/show_bug.cgi?id=194357
+ <rdar://problem/47861231>
+
+ Reviewed by Chris Dumez.
+
+ Bug 194124 was supposed to enable the automatic checking and
+ regenerating of .xcfilelist files during the build. While related
+ changes were included in that patch, the change to actually enable the
+ operation somehow was omitted. This patch actually enables the
+ operation. The check-xcfilelist.sh scripts now check
+ WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
+ from the checking.
+
+ * Scripts/check-xcfilelists.sh:
+
2019-02-06 John Wilander <[email protected]>
Forward Ad Click Attribution data from HTMLAnchorElement::handleClick() to WebKit::NavigationActionData
Modified: trunk/Source/WebKit/Scripts/check-xcfilelists.sh (241102 => 241103)
--- trunk/Source/WebKit/Scripts/check-xcfilelists.sh 2019-02-06 22:18:36 UTC (rev 241102)
+++ trunk/Source/WebKit/Scripts/check-xcfilelists.sh 2019-02-06 22:54:54 UTC (rev 241103)
@@ -1,6 +1,6 @@
#!/bin/sh
-[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; }
+[ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
[ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
[ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
Modified: trunk/Tools/ChangeLog (241102 => 241103)
--- trunk/Tools/ChangeLog 2019-02-06 22:18:36 UTC (rev 241102)
+++ trunk/Tools/ChangeLog 2019-02-06 22:54:54 UTC (rev 241103)
@@ -1,3 +1,22 @@
+2019-02-06 Keith Rollin <[email protected]>
+
+ Really enable the automatic checking and regenerations of .xcfilelists during builds
+ https://bugs.webkit.org/show_bug.cgi?id=194357
+ <rdar://problem/47861231>
+
+ Reviewed by Chris Dumez.
+
+ Bug 194124 was supposed to enable the automatic checking and
+ regenerating of .xcfilelist files during the build. While related
+ changes were included in that patch, the change to actually enable the
+ operation somehow was omitted. This patch actually enables the
+ operation. The check-xcfilelist.sh scripts now check
+ WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
+ from the checking.
+
+ * DumpRenderTree/Scripts/check-xcfilelists.sh:
+ * WebKitTestRunner/Scripts/check-xcfilelists.sh:
+
2019-02-06 David Kilzer <[email protected]>
WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
Modified: trunk/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh (241102 => 241103)
--- trunk/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh 2019-02-06 22:18:36 UTC (rev 241102)
+++ trunk/Tools/DumpRenderTree/Scripts/check-xcfilelists.sh 2019-02-06 22:54:54 UTC (rev 241103)
@@ -1,6 +1,6 @@
#!/bin/sh
-[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; }
+[ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
[ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
[ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
Modified: trunk/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh (241102 => 241103)
--- trunk/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh 2019-02-06 22:18:36 UTC (rev 241102)
+++ trunk/Tools/WebKitTestRunner/Scripts/check-xcfilelists.sh 2019-02-06 22:54:54 UTC (rev 241103)
@@ -1,6 +1,6 @@
#!/bin/sh
-[ "${WK_ENABLE_CHECK_XCFILELISTS}" == "" ] && { echo "### Not running because WK_ENABLE_CHECK_XCFILELISTS is not set"; exit 0; }
+[ "${WK_DISABLE_CHECK_XCFILELISTS}" == "1" ] && { echo "### Not running because WK_DISABLE_CHECK_XCFILELISTS is set"; exit 0; }
[ "${DEPLOYMENT_LOCATION}" == "YES" ] && { echo "### Not running because DEPLOYMENT_LOCATION is YES"; exit 0; }
[ "${USE_INTERNAL_SDK}" == "YES" ] || { echo "### Not running because USE_INTERNAL_SDK is not YES"; exit 0; }
