Title: [241144] trunk/LayoutTests
Revision
241144
Author
[email protected]
Date
2019-02-07 14:15:09 -0800 (Thu, 07 Feb 2019)

Log Message

Web Inspector: Fix modify-css-property-race.html flakiness
https://bugs.webkit.org/show_bug.cgi?id=194408

Reviewed by Devin Rousso.

Event listener wasn't removed property, sometimes causing it to fire one more time.

* inspector/css/modify-css-property-race.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (241143 => 241144)


--- trunk/LayoutTests/ChangeLog	2019-02-07 22:11:57 UTC (rev 241143)
+++ trunk/LayoutTests/ChangeLog	2019-02-07 22:15:09 UTC (rev 241144)
@@ -1,3 +1,14 @@
+2019-02-07  Nikita Vasilyev  <[email protected]>
+
+        Web Inspector: Fix modify-css-property-race.html flakiness
+        https://bugs.webkit.org/show_bug.cgi?id=194408
+
+        Reviewed by Devin Rousso.
+
+        Event listener wasn't removed property, sometimes causing it to fire one more time.
+
+        * inspector/css/modify-css-property-race.html:
+
 2019-02-07  Youenn Fablet  <[email protected]>
 
         Unable to sign in leetcode.

Modified: trunk/LayoutTests/inspector/css/modify-css-property-race.html (241143 => 241144)


--- trunk/LayoutTests/inspector/css/modify-css-property-race.html	2019-02-07 22:11:57 UTC (rev 241143)
+++ trunk/LayoutTests/inspector/css/modify-css-property-race.html	2019-02-07 22:15:09 UTC (rev 241144)
@@ -61,6 +61,7 @@
 
             InspectorTest.evaluateInPage("expand()");
             let updateCount = 0;
+            let style = getInlineStyleDeclaration();
 
             function styleDecorationUpdated() {
                 ++updateCount;
@@ -77,12 +78,11 @@
                     InspectorTest.expectGreaterThanOrEqual(heightNumber, 101, "Height should be 101px or more.");
 
                     InspectorTest.evaluateInPage("stopExpanding()");
-                    WI.CSSStyleDeclaration.removeEventListener(WI.CSSStyleDeclaration.Event.PropertiesChanged, styleDecorationUpdated);
+                    style.removeEventListener(WI.CSSStyleDeclaration.Event.PropertiesChanged, styleDecorationUpdated);
                     resolve();
                 }
             }
 
-            let style = getInlineStyleDeclaration();
             style.addEventListener(WI.CSSStyleDeclaration.Event.PropertiesChanged, styleDecorationUpdated);
         }
     });
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to