- Revision
- 241202
- Author
- [email protected]
- Date
- 2019-02-08 11:46:11 -0800 (Fri, 08 Feb 2019)
Log Message
webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
https://bugs.webkit.org/show_bug.cgi?id=194418
Reviewed by Lucas Forschler.
Do not include errors trying when finding crashlogs at the end of
a run-webkit-tests run since we don't process those errors.
* Scripts/webkitpy/port/darwin.py:
(DarwinPort._look_for_all_crash_logs_in_log_dir):
* Scripts/webkitpy/port/ios_device.py:
(IOSDevicePort._look_for_all_crash_logs_in_log_dir):
* Scripts/webkitpy/port/watch_device.py:
(WatchDevicePort._look_for_all_crash_logs_in_log_dir):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (241201 => 241202)
--- trunk/Tools/ChangeLog 2019-02-08 19:18:14 UTC (rev 241201)
+++ trunk/Tools/ChangeLog 2019-02-08 19:46:11 UTC (rev 241202)
@@ -1,3 +1,20 @@
+2019-02-08 Jonathan Bedard <[email protected]>
+
+ webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
+ https://bugs.webkit.org/show_bug.cgi?id=194418
+
+ Reviewed by Lucas Forschler.
+
+ Do not include errors trying when finding crashlogs at the end of
+ a run-webkit-tests run since we don't process those errors.
+
+ * Scripts/webkitpy/port/darwin.py:
+ (DarwinPort._look_for_all_crash_logs_in_log_dir):
+ * Scripts/webkitpy/port/ios_device.py:
+ (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
+ * Scripts/webkitpy/port/watch_device.py:
+ (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
+
2019-02-08 Beth Dakin <[email protected]>
Add afterScreenUpdates to WKSnapshotConfiguration
Modified: trunk/Tools/Scripts/webkitpy/port/darwin.py (241201 => 241202)
--- trunk/Tools/Scripts/webkitpy/port/darwin.py 2019-02-08 19:18:14 UTC (rev 241201)
+++ trunk/Tools/Scripts/webkitpy/port/darwin.py 2019-02-08 19:46:11 UTC (rev 241202)
@@ -113,7 +113,7 @@
def _look_for_all_crash_logs_in_log_dir(self, newer_than):
crash_log = CrashLogs(self.host, self.path_to_crash_logs(), crash_logs_to_skip=self._crash_logs_to_skip_for_host.get(self.host, []))
- return crash_log.find_all_logs(include_errors=True, newer_than=newer_than)
+ return crash_log.find_all_logs(newer_than=newer_than)
def _get_crash_log(self, name, pid, stdout, stderr, newer_than, time_fn=None, sleep_fn=None, wait_for_log=True, target_host=None):
# Note that we do slow-spin here and wait, since it appears the time
Modified: trunk/Tools/Scripts/webkitpy/port/ios_device.py (241201 => 241202)
--- trunk/Tools/Scripts/webkitpy/port/ios_device.py 2019-02-08 19:18:14 UTC (rev 241201)
+++ trunk/Tools/Scripts/webkitpy/port/ios_device.py 2019-02-08 19:46:11 UTC (rev 241202)
@@ -67,7 +67,7 @@
log_list = {}
for device in self.devices():
crash_log = CrashLogs(device, self.path_to_crash_logs(), crash_logs_to_skip=self._crash_logs_to_skip_for_host.get(device, []))
- log_list.update(crash_log.find_all_logs(include_errors=True, newer_than=newer_than))
+ log_list.update(crash_log.find_all_logs(newer_than=newer_than))
return log_list
def _get_crash_log(self, name, pid, stdout, stderr, newer_than, time_fn=None, sleep_fn=None, wait_for_log=True, target_host=None):
Modified: trunk/Tools/Scripts/webkitpy/port/watch_device.py (241201 => 241202)
--- trunk/Tools/Scripts/webkitpy/port/watch_device.py 2019-02-08 19:18:14 UTC (rev 241201)
+++ trunk/Tools/Scripts/webkitpy/port/watch_device.py 2019-02-08 19:46:11 UTC (rev 241202)
@@ -65,7 +65,7 @@
log_list = {}
for device in self.devices():
crash_log = CrashLogs(device, self.path_to_crash_logs(), crash_logs_to_skip=self._crash_logs_to_skip_for_host.get(device, []))
- log_list.update(crash_log.find_all_logs(include_errors=True, newer_than=newer_than))
+ log_list.update(crash_log.find_all_logs(newer_than=newer_than))
return log_list
def _get_crash_log(self, name, pid, stdout, stderr, newer_than, time_fn=None, sleep_fn=None, wait_for_log=True, target_host=None):
