Title: [241227] trunk/Source/WebInspectorUI
- Revision
- 241227
- Author
- [email protected]
- Date
- 2019-02-08 18:31:52 -0800 (Fri, 08 Feb 2019)
Log Message
Web Inspector: Audit: show keyboard shortcut in export tooltip
https://bugs.webkit.org/show_bug.cgi?id=194454
Reviewed by Matt Baker.
* UserInterface/Views/AuditTestContentView.js:
(WI.AuditTestContentView):
(WI.AuditTestContentView.prototype.get saveData):
(WI.AuditTestContentView.prototype._exportResult): Added.
(WI.AuditTestContentView.prototype._handleExportButtonNavigationItemClicked):
(WI.AuditTestContentView.prototype._exportAudit): Deleted.
* Localizations/en.lproj/localizedStrings.js:
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (241226 => 241227)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-02-09 01:47:08 UTC (rev 241226)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-02-09 02:31:52 UTC (rev 241227)
@@ -1,3 +1,19 @@
+2019-02-08 Devin Rousso <[email protected]>
+
+ Web Inspector: Audit: show keyboard shortcut in export tooltip
+ https://bugs.webkit.org/show_bug.cgi?id=194454
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Views/AuditTestContentView.js:
+ (WI.AuditTestContentView):
+ (WI.AuditTestContentView.prototype.get saveData):
+ (WI.AuditTestContentView.prototype._exportResult): Added.
+ (WI.AuditTestContentView.prototype._handleExportButtonNavigationItemClicked):
+ (WI.AuditTestContentView.prototype._exportAudit): Deleted.
+
+ * Localizations/en.lproj/localizedStrings.js:
+
2019-02-08 Nikita Vasilyev <[email protected]>
Web Inspector: Styles: easier way to select a single line
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (241226 => 241227)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-02-09 01:47:08 UTC (rev 241226)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2019-02-09 02:31:52 UTC (rev 241227)
@@ -423,6 +423,7 @@
localizedStrings["Export Result"] = "Export Result";
localizedStrings["Export Test"] = "Export Test";
localizedStrings["Export recording (%s)"] = "Export recording (%s)";
+localizedStrings["Export result (%s)"] = "Export result (%s)";
localizedStrings["_expression_"] = "_expression_";
localizedStrings["Extension Scripts"] = "Extension Scripts";
localizedStrings["Extensions"] = "Extensions";
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.js (241226 => 241227)
--- trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.js 2019-02-09 01:47:08 UTC (rev 241226)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.js 2019-02-09 02:31:52 UTC (rev 241227)
@@ -34,6 +34,7 @@
this.element.classList.add("audit-test");
this._exportButtonNavigationItem = new WI.ButtonNavigationItem("audit-export", WI.UIString("Export"), "Images/Export.svg", 15, 15);
+ this._exportButtonNavigationItem.tooltip = WI.UIString("Export result (%s)").format(WI.saveKeyboardShortcut.displayName);
this._exportButtonNavigationItem.buttonStyle = WI.ButtonNavigationItem.Style.ImageAndText;
this._exportButtonNavigationItem.visibilityPriority = WI.NavigationItem.VisibilityPriority.Low;
this._exportButtonNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, this._handleExportButtonNavigationItemClicked, this);
@@ -65,7 +66,7 @@
get saveData()
{
- return {customSaveHandler: () => { this._exportAudit(); }};
+ return {customSaveHandler: () => { this._exportResult(); }};
}
get result()
@@ -262,7 +263,7 @@
// Private
- _exportAudit()
+ _exportResult()
{
WI.auditManager.export(this.representedObject.result);
}
@@ -280,7 +281,7 @@
_handleExportButtonNavigationItemClicked(event)
{
- this._exportAudit();
+ this._exportResult();
}
_handleTestChanged(event)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
