Title: [241262] trunk/Source/WebKit
- Revision
- 241262
- Author
- [email protected]
- Date
- 2019-02-11 06:08:00 -0800 (Mon, 11 Feb 2019)
Log Message
[WPE] Do not try to create empty egl windows
https://bugs.webkit.org/show_bug.cgi?id=194497
Reviewed by Žan Doberšek.
In AcceleratedSurfaceWPE we ensure the size we pass to wpe is at least 0x0, but wl_egl_window_create() returns
nullptr if 0 is passed as width or height. We should use at least 1x1 instead.
* WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp:
(WebKit::AcceleratedSurfaceWPE::initialize):
(WebKit::AcceleratedSurfaceWPE::clientResize):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (241261 => 241262)
--- trunk/Source/WebKit/ChangeLog 2019-02-11 12:14:50 UTC (rev 241261)
+++ trunk/Source/WebKit/ChangeLog 2019-02-11 14:08:00 UTC (rev 241262)
@@ -1,3 +1,17 @@
+2019-02-11 Carlos Garcia Campos <[email protected]>
+
+ [WPE] Do not try to create empty egl windows
+ https://bugs.webkit.org/show_bug.cgi?id=194497
+
+ Reviewed by Žan Doberšek.
+
+ In AcceleratedSurfaceWPE we ensure the size we pass to wpe is at least 0x0, but wl_egl_window_create() returns
+ nullptr if 0 is passed as width or height. We should use at least 1x1 instead.
+
+ * WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp:
+ (WebKit::AcceleratedSurfaceWPE::initialize):
+ (WebKit::AcceleratedSurfaceWPE::clientResize):
+
2019-02-10 Carlos Garcia Campos <[email protected]>
[WPE] Do not use a sync IPC message to send the host FD to the web process
Modified: trunk/Source/WebKit/WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp (241261 => 241262)
--- trunk/Source/WebKit/WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp 2019-02-11 12:14:50 UTC (rev 241261)
+++ trunk/Source/WebKit/WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp 2019-02-11 14:08:00 UTC (rev 241262)
@@ -66,7 +66,7 @@
};
wpe_renderer_backend_egl_target_set_client(m_backend, &s_client, this);
wpe_renderer_backend_egl_target_initialize(m_backend, downcast<PlatformDisplayLibWPE>(PlatformDisplay::sharedDisplay()).backend(),
- std::max(0, m_size.width()), std::max(0, m_size.height()));
+ std::max(1, m_size.width()), std::max(1, m_size.height()));
}
void AcceleratedSurfaceWPE::finalize()
@@ -94,7 +94,7 @@
void AcceleratedSurfaceWPE::clientResize(const IntSize& size)
{
ASSERT(m_backend);
- wpe_renderer_backend_egl_target_resize(m_backend, std::max(0, m_size.width()), std::max(0, m_size.height()));
+ wpe_renderer_backend_egl_target_resize(m_backend, std::max(1, m_size.width()), std::max(1, m_size.height()));
}
void AcceleratedSurfaceWPE::willRenderFrame()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes