Title: [241296] trunk/Source/WebCore
- Revision
- 241296
- Author
- [email protected]
- Date
- 2019-02-12 08:22:18 -0800 (Tue, 12 Feb 2019)
Log Message
Crash in WebCore::ScrollingTree::updateTreeFromStateNode
https://bugs.webkit.org/show_bug.cgi?id=194538
<rdar://problem/47841926>
Reviewed by Zalan Bujtas.
* page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::updateTreeFromStateNode):
Make sure we don't leave node entry behind in m_nodeMap in case we failed to add it to the parent.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (241295 => 241296)
--- trunk/Source/WebCore/ChangeLog 2019-02-12 15:59:16 UTC (rev 241295)
+++ trunk/Source/WebCore/ChangeLog 2019-02-12 16:22:18 UTC (rev 241296)
@@ -1,3 +1,16 @@
+2019-02-12 Antti Koivisto <[email protected]>
+
+ Crash in WebCore::ScrollingTree::updateTreeFromStateNode
+ https://bugs.webkit.org/show_bug.cgi?id=194538
+ <rdar://problem/47841926>
+
+ Reviewed by Zalan Bujtas.
+
+ * page/scrolling/ScrollingTree.cpp:
+ (WebCore::ScrollingTree::updateTreeFromStateNode):
+
+ Make sure we don't leave node entry behind in m_nodeMap in case we failed to add it to the parent.
+
2019-02-12 Zalan Bujtas <[email protected]>
[LFC] Remove redundant InlineFormattingContext::computeBorderAndPadding
Modified: trunk/Source/WebCore/page/scrolling/ScrollingTree.cpp (241295 => 241296)
--- trunk/Source/WebCore/page/scrolling/ScrollingTree.cpp 2019-02-12 15:59:16 UTC (rev 241295)
+++ trunk/Source/WebCore/page/scrolling/ScrollingTree.cpp 2019-02-12 16:22:18 UTC (rev 241296)
@@ -229,6 +229,9 @@
auto* parent = parentIt->value;
node->setParent(parent);
parent->appendChild(*node);
+ } else {
+ // FIXME: Use WeakPtr in m_nodeMap.
+ m_nodeMap.remove(nodeID);
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes