Title: [241303] trunk/Source/WebKit
- Revision
- 241303
- Author
- [email protected]
- Date
- 2019-02-12 10:23:43 -0800 (Tue, 12 Feb 2019)
Log Message
Ensure old binaries have old snapshotting behaviors
https://bugs.webkit.org/show_bug.cgi?id=194449
-and corresponding-
rdar://problem/47931954
Reviewed by Darin Adler.
Make sure that a nil configuration behaves the same way that it used to on apps
that were linked before FirstWithSnapshotAfterScreenUpdates
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView takeSnapshotWithConfiguration:completionHandler:]):
* UIProcess/Cocoa/VersionChecks.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (241302 => 241303)
--- trunk/Source/WebKit/ChangeLog 2019-02-12 18:22:40 UTC (rev 241302)
+++ trunk/Source/WebKit/ChangeLog 2019-02-12 18:23:43 UTC (rev 241303)
@@ -1,3 +1,19 @@
+2019-02-08 Beth Dakin <[email protected]>
+
+ Ensure old binaries have old snapshotting behaviors
+ https://bugs.webkit.org/show_bug.cgi?id=194449
+ -and corresponding-
+ rdar://problem/47931954
+
+ Reviewed by Darin Adler.
+
+ Make sure that a nil configuration behaves the same way that it used to on apps
+ that were linked before FirstWithSnapshotAfterScreenUpdates
+
+ * UIProcess/API/Cocoa/WKWebView.mm:
+ (-[WKWebView takeSnapshotWithConfiguration:completionHandler:]):
+ * UIProcess/Cocoa/VersionChecks.h:
+
2019-02-12 Andy Estes <[email protected]>
[iOSMac] Enable Parental Controls Content Filtering
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (241302 => 241303)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2019-02-12 18:22:40 UTC (rev 241302)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2019-02-12 18:23:43 UTC (rev 241303)
@@ -1185,7 +1185,7 @@
}];
};
- if (snapshotConfiguration && !snapshotConfiguration.afterScreenUpdates) {
+ if ((snapshotConfiguration && !snapshotConfiguration.afterScreenUpdates) || !linkedOnOrAfter(WebKit::SDKVersion::FirstWithSnapshotAfterScreenUpdates)) {
callSnapshotRect();
return;
}
Modified: trunk/Source/WebKit/UIProcess/Cocoa/VersionChecks.h (241302 => 241303)
--- trunk/Source/WebKit/UIProcess/Cocoa/VersionChecks.h 2019-02-12 18:22:40 UTC (rev 241302)
+++ trunk/Source/WebKit/UIProcess/Cocoa/VersionChecks.h 2019-02-12 18:23:43 UTC (rev 241303)
@@ -32,6 +32,8 @@
#else
#define DYLD_IOS_VERSION_FIRST_WITH_LAZY_GESTURE_RECOGNIZER_INSTALLATION 0
#define DYLD_IOS_VERSION_FIRST_WITH_PROCESS_SWAP_ON_CROSS_SITE_NAVIGATION 0
+#define DYLD_IOS_VERSION_FIRST_WITH_SNAPSHOT_AFTER_SCREEN_UPDATES 0
+#define DYLD_MACOS_VERSION_FIRST_WITH_SNAPSHOT_AFTER_SCREEN_UPDATES 0
#endif
namespace WebKit {
@@ -50,6 +52,7 @@
FirstWithMainThreadReleaseAssertionInWebPageProxy = DYLD_IOS_VERSION_12_0,
FirstWithLazyGestureRecognizerInstallation = DYLD_IOS_VERSION_FIRST_WITH_LAZY_GESTURE_RECOGNIZER_INSTALLATION,
FirstWithProcessSwapOnCrossSiteNavigation = DYLD_IOS_VERSION_FIRST_WITH_PROCESS_SWAP_ON_CROSS_SITE_NAVIGATION,
+ FirstWithSnapshotAfterScreenUpdates = DYLD_IOS_VERSION_FIRST_WITH_SNAPSHOT_AFTER_SCREEN_UPDATES,
#elif PLATFORM(MAC)
FirstWithNetworkCache = DYLD_MACOSX_VERSION_10_11,
FirstWithExceptionsForDuplicateCompletionHandlerCalls = DYLD_MACOSX_VERSION_10_13,
@@ -56,6 +59,7 @@
FirstWithDropToNavigateDisallowedByDefault = DYLD_MACOSX_VERSION_10_13,
FirstWithExpiredOnlyReloadBehavior = DYLD_MACOSX_VERSION_10_13,
FirstWithMainThreadReleaseAssertionInWebPageProxy = DYLD_MACOSX_VERSION_10_14,
+ FirstWithSnapshotAfterScreenUpdates = DYLD_MACOS_VERSION_FIRST_WITH_SNAPSHOT_AFTER_SCREEN_UPDATES,
#endif
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes