Title: [241307] trunk/LayoutTests
- Revision
- 241307
- Author
- [email protected]
- Date
- 2019-02-12 11:51:02 -0800 (Tue, 12 Feb 2019)
Log Message
AX: Fix flaky accessibility/loading-iframe-sends-notification.html
https://bugs.webkit.org/show_bug.cgi?id=194546
Reviewed by Zalan Bujtas.
This test was relying on timing between load events being sent and accessibility events being sent.
We don't need to do that, we can more directly test this interplay.
* accessibility/loading-iframe-sends-notification-expected.txt:
* accessibility/loading-iframe-sends-notification.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (241306 => 241307)
--- trunk/LayoutTests/ChangeLog 2019-02-12 19:29:21 UTC (rev 241306)
+++ trunk/LayoutTests/ChangeLog 2019-02-12 19:51:02 UTC (rev 241307)
@@ -1,3 +1,16 @@
+2019-02-12 Chris Fleizach <[email protected]>
+
+ AX: Fix flaky accessibility/loading-iframe-sends-notification.html
+ https://bugs.webkit.org/show_bug.cgi?id=194546
+
+ Reviewed by Zalan Bujtas.
+
+ This test was relying on timing between load events being sent and accessibility events being sent.
+ We don't need to do that, we can more directly test this interplay.
+
+ * accessibility/loading-iframe-sends-notification-expected.txt:
+ * accessibility/loading-iframe-sends-notification.html:
+
2019-02-12 Adrian Perez de Castro <[email protected]>
Unreviewed WPE gardening. Unskip content extensions tests after r241283
Modified: trunk/LayoutTests/accessibility/loading-iframe-sends-notification-expected.txt (241306 => 241307)
--- trunk/LayoutTests/accessibility/loading-iframe-sends-notification-expected.txt 2019-02-12 19:29:21 UTC (rev 241306)
+++ trunk/LayoutTests/accessibility/loading-iframe-sends-notification-expected.txt 2019-02-12 19:51:02 UTC (rev 241307)
@@ -13,7 +13,6 @@
PASS findByAccessibleTitleSubstring(root, 'InnerButton') != null is false
Got notification on iframe.
PASS findByAccessibleTitleSubstring(root, 'InnerButton') != null is true
-PASS gotIframeNotification is true
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/accessibility/loading-iframe-sends-notification.html (241306 => 241307)
--- trunk/LayoutTests/accessibility/loading-iframe-sends-notification.html 2019-02-12 19:29:21 UTC (rev 241306)
+++ trunk/LayoutTests/accessibility/loading-iframe-sends-notification.html 2019-02-12 19:51:02 UTC (rev 241307)
@@ -42,8 +42,6 @@
function runTest()
{
- window.gotIframeNotification = false;
-
if (window.accessibilityController) {
window.root = accessibilityController.rootElement;
@@ -59,24 +57,16 @@
return;
debug("Got notification on iframe.");
- gotIframeNotification = true;
// Check that the button within the iframe is now reachable from the root.
shouldBeTrue("findByAccessibleTitleSubstring(root, 'InnerButton') != null");
+ accessibilityController.removeNotificationListener();
+ finishJSTest();
});
}
window.iframeElement = document.getElementById("iframe");
- iframeElement.addEventListener("load", function() {
- window.setTimeout(function() {
- shouldBeTrue("gotIframeNotification");
- if (window.accessibilityController)
- accessibilityController.removeNotificationListener();
- finishJSTest();
- }, 10);
- }, false);
-
// Load content into the iframe. This will trigger the event
// handler above, which will check that the accessibility tree
// was updated with new content.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes