Title: [241354] branches/safari-608.1.5.1-branch/Source/WebInspectorUI
- Revision
- 241354
- Author
- [email protected]
- Date
- 2019-02-13 01:02:20 -0800 (Wed, 13 Feb 2019)
Log Message
Cherry-pick r240947. rdar://problem/47743864
Web Inspector: REGRESSION: clicking a selected call frame doesn't re-scroll
https://bugs.webkit.org/show_bug.cgi?id=194169
<rdar://problem/47743864>
Reviewed by Devin Rousso.
* UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype._handleMouseDown):
Add a special case for a single-selection TreeOutline with
allowsRepeatSelection enabled. Since the element is already
selected, bypass the SelectionCongroller and dispatch an
event with event.data.selectedByUser set to true.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-608.1.5.1-branch/Source/WebInspectorUI/ChangeLog (241353 => 241354)
--- branches/safari-608.1.5.1-branch/Source/WebInspectorUI/ChangeLog 2019-02-13 09:02:15 UTC (rev 241353)
+++ branches/safari-608.1.5.1-branch/Source/WebInspectorUI/ChangeLog 2019-02-13 09:02:20 UTC (rev 241354)
@@ -1,5 +1,40 @@
2019-02-13 Babak Shafiei <[email protected]>
+ Cherry-pick r240947. rdar://problem/47743864
+
+ Web Inspector: REGRESSION: clicking a selected call frame doesn't re-scroll
+ https://bugs.webkit.org/show_bug.cgi?id=194169
+ <rdar://problem/47743864>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/TreeOutline.js:
+ (WI.TreeOutline.prototype._handleMouseDown):
+ Add a special case for a single-selection TreeOutline with
+ allowsRepeatSelection enabled. Since the element is already
+ selected, bypass the SelectionCongroller and dispatch an
+ event with event.data.selectedByUser set to true.
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-02-04 Matt Baker <[email protected]>
+
+ Web Inspector: REGRESSION: clicking a selected call frame doesn't re-scroll
+ https://bugs.webkit.org/show_bug.cgi?id=194169
+ <rdar://problem/47743864>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/TreeOutline.js:
+ (WI.TreeOutline.prototype._handleMouseDown):
+ Add a special case for a single-selection TreeOutline with
+ allowsRepeatSelection enabled. Since the element is already
+ selected, bypass the SelectionCongroller and dispatch an
+ event with event.data.selectedByUser set to true.
+
+2019-02-13 Babak Shafiei <[email protected]>
+
Cherry-pick r240946. rdar://problem/47827420
Web Inspector: Styles: fix race conditions when editing
Modified: branches/safari-608.1.5.1-branch/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (241353 => 241354)
--- branches/safari-608.1.5.1-branch/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2019-02-13 09:02:15 UTC (rev 241353)
+++ branches/safari-608.1.5.1-branch/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2019-02-13 09:02:20 UTC (rev 241354)
@@ -1015,6 +1015,14 @@
if (!treeElement.canSelectOnMouseDown(event))
return;
+ if (this.allowsRepeatSelection && treeElement.selected && this._selectionController.selectedItems.size === 1) {
+ // Special case for dispatching a selection event for an already selected
+ // item in single-selection mode.
+ this._itemWasSelectedByUser = true;
+ this._dispatchSelectionDidChangeEvent();
+ return;
+ }
+
let index = this._indexOfTreeElement(treeElement);
if (isNaN(index))
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
