Title: [241517] releases/WebKitGTK/webkit-2.24/Source/_javascript_Core
- Revision
- 241517
- Author
- [email protected]
- Date
- 2019-02-14 03:26:32 -0800 (Thu, 14 Feb 2019)
Log Message
Merge r241431 - SourceCode should be copied when generating bytecode for functions
https://bugs.webkit.org/show_bug.cgi?id=194536
Reviewed by Saam Barati.
The FunctionExecutable might be collected while generating the bytecode
for nested functions, in which case the SourceCode reference would no
longer be valid.
* runtime/CodeCache.cpp:
(JSC::generateUnlinkedCodeBlockForFunctions):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/ChangeLog (241516 => 241517)
--- releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/ChangeLog 2019-02-14 11:26:28 UTC (rev 241516)
+++ releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/ChangeLog 2019-02-14 11:26:32 UTC (rev 241517)
@@ -1,3 +1,17 @@
+2019-02-13 Tadeu Zagallo <[email protected]>
+
+ SourceCode should be copied when generating bytecode for functions
+ https://bugs.webkit.org/show_bug.cgi?id=194536
+
+ Reviewed by Saam Barati.
+
+ The FunctionExecutable might be collected while generating the bytecode
+ for nested functions, in which case the SourceCode reference would no
+ longer be valid.
+
+ * runtime/CodeCache.cpp:
+ (JSC::generateUnlinkedCodeBlockForFunctions):
+
2019-02-12 Robin Morisset <[email protected]>
Make B3Value::returnsBool() more precise
Modified: releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/runtime/CodeCache.cpp (241516 => 241517)
--- releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/runtime/CodeCache.cpp 2019-02-14 11:26:28 UTC (rev 241516)
+++ releases/WebKitGTK/webkit-2.24/Source/_javascript_Core/runtime/CodeCache.cpp 2019-02-14 11:26:32 UTC (rev 241517)
@@ -170,7 +170,9 @@
return;
FunctionExecutable* executable = unlinkedExecutable->link(vm, parentSource);
- const SourceCode& source = executable->source();
+ // FIXME: We shouldn't need to create a FunctionExecutable just to get its source code
+ // https://bugs.webkit.org/show_bug.cgi?id=194576
+ SourceCode source = executable->source();
UnlinkedFunctionCodeBlock* unlinkedFunctionCodeBlock = unlinkedExecutable->unlinkedCodeBlockFor(vm, source, constructorKind, debuggerMode, error, unlinkedExecutable->parseMode());
if (unlinkedFunctionCodeBlock)
generateUnlinkedCodeBlockForFunctions(vm, unlinkedFunctionCodeBlock, source, debuggerMode, error);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
