Title: [241598] trunk/Source/WebCore
- Revision
- 241598
- Author
- [email protected]
- Date
- 2019-02-15 11:06:47 -0800 (Fri, 15 Feb 2019)
Log Message
Performance should not fire events when its context is stopped
https://bugs.webkit.org/show_bug.cgi?id=194689
Reviewed by Alex Christensen.
Stop the timer when its context is destroyed.
Add an assertion to ensure the timer does not fire after context is destroyed.
* page/Performance.cpp:
(WebCore::Performance::stop):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (241597 => 241598)
--- trunk/Source/WebCore/ChangeLog 2019-02-15 19:01:52 UTC (rev 241597)
+++ trunk/Source/WebCore/ChangeLog 2019-02-15 19:06:47 UTC (rev 241598)
@@ -1,3 +1,16 @@
+2019-02-15 Youenn Fablet <[email protected]>
+
+ Performance should not fire events when its context is stopped
+ https://bugs.webkit.org/show_bug.cgi?id=194689
+
+ Reviewed by Alex Christensen.
+
+ Stop the timer when its context is destroyed.
+ Add an assertion to ensure the timer does not fire after context is destroyed.
+
+ * page/Performance.cpp:
+ (WebCore::Performance::stop):
+
2019-02-15 Alex Christensen <[email protected]>
REGRESSION: ( r240978-r240985 ) [ iOS Release ] Layout Test imported/w3c/web-platform-tests/xhr/send-redirect-post-upload.htm is crashing
Modified: trunk/Source/WebCore/page/Performance.cpp (241597 => 241598)
--- trunk/Source/WebCore/page/Performance.cpp 2019-02-15 19:01:52 UTC (rev 241597)
+++ trunk/Source/WebCore/page/Performance.cpp 2019-02-15 19:06:47 UTC (rev 241598)
@@ -64,7 +64,7 @@
void Performance::contextDestroyed()
{
m_performanceTimelineTaskQueue.close();
-
+ m_resourceTimingBufferFullTimer.stop();
ContextDestructionObserver::contextDestroyed();
}
@@ -211,6 +211,8 @@
void Performance::resourceTimingBufferFullTimerFired()
{
+ ASSERT(scriptExecutionContext());
+
while (!m_backupResourceTimingBuffer.isEmpty()) {
auto backupBuffer = WTFMove(m_backupResourceTimingBuffer);
ASSERT(m_backupResourceTimingBuffer.isEmpty());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
