Title: [102160] trunk/Source/WebKit2
Revision
102160
Author
simon.fra...@apple.com
Date
2011-12-06 11:58:41 -0800 (Tue, 06 Dec 2011)

Log Message

UI process crashes if the Web Process crashes on launch
https://bugs.webkit.org/show_bug.cgi?id=73943

Reviewed by Sam Weinig.

When the Web Process crashes on launch, the WebConnectionToWebProcess
object was getting deleted inside of didClose. Add a protector to
prevent this.

* UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::didClose):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (102159 => 102160)


--- trunk/Source/WebKit2/ChangeLog	2011-12-06 19:29:44 UTC (rev 102159)
+++ trunk/Source/WebKit2/ChangeLog	2011-12-06 19:58:41 UTC (rev 102160)
@@ -1,3 +1,17 @@
+2011-12-06  Simon Fraser  <simon.fra...@apple.com>
+
+        UI process crashes if the Web Process crashes on launch
+        https://bugs.webkit.org/show_bug.cgi?id=73943
+
+        Reviewed by Sam Weinig.
+        
+        When the Web Process crashes on launch, the WebConnectionToWebProcess
+        object was getting deleted inside of didClose. Add a protector to
+        prevent this.
+
+        * UIProcess/WebConnectionToWebProcess.cpp:
+        (WebKit::WebConnectionToWebProcess::didClose):
+
 2011-12-06  Jocelyn Turcotte  <jocelyn.turco...@nokia.com>
 
         [Qt] Fix page overlay rendering with AC.

Modified: trunk/Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp (102159 => 102160)


--- trunk/Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp	2011-12-06 19:29:44 UTC (rev 102159)
+++ trunk/Source/WebKit2/UIProcess/WebConnectionToWebProcess.cpp	2011-12-06 19:58:41 UTC (rev 102160)
@@ -83,6 +83,8 @@
 
 void WebConnectionToWebProcess::didClose(CoreIPC::Connection* connection)
 {
+    RefPtr<WebConnectionToWebProcess> protector(this);
+
     m_process->didClose(connection);
 
     // Tell the API client that the connection closed.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to