Title: [241744] trunk/Source/WebInspectorUI
- Revision
- 241744
- Author
- [email protected]
- Date
- 2019-02-18 15:27:07 -0800 (Mon, 18 Feb 2019)
Log Message
Web Inspector: Fix a typo causing assertions in ConsoleManager
https://bugs.webkit.org/show_bug.cgi?id=194792
Patch by Joseph Pecoraro <[email protected]> on 2019-02-18
Reviewed by Matt Baker.
* UserInterface/Controllers/ConsoleManager.js:
(WI.ConsoleManager.prototype.initializeLogChannels):
Extra comma produced an undefined value in the list.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (241743 => 241744)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-02-18 23:13:58 UTC (rev 241743)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-02-18 23:27:07 UTC (rev 241744)
@@ -1,3 +1,14 @@
+2019-02-18 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Fix a typo causing assertions in ConsoleManager
+ https://bugs.webkit.org/show_bug.cgi?id=194792
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Controllers/ConsoleManager.js:
+ (WI.ConsoleManager.prototype.initializeLogChannels):
+ Extra comma produced an undefined value in the list.
+
2019-02-18 Nikita Vasilyev <[email protected]>
Web Inspector: Styles: typing ";" shouldn't focus on the next property when there's open parenthesis or comment
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js (241743 => 241744)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js 2019-02-18 23:13:58 UTC (rev 241743)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js 2019-02-18 23:27:07 UTC (rev 241744)
@@ -160,7 +160,7 @@
if (this._loggingChannelSources.length)
return;
- this._loggingChannelSources = [WI.ConsoleMessage.MessageSource.Media, WI.ConsoleMessage.MessageSource.WebRTC, , WI.ConsoleMessage.MessageSource.MessageSource];
+ this._loggingChannelSources = [WI.ConsoleMessage.MessageSource.Media, WI.ConsoleMessage.MessageSource.WebRTC, WI.ConsoleMessage.MessageSource.MessageSource];
target.ConsoleAgent.getLoggingChannels((error, channels) => {
if (error)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes