Title: [241754] trunk
- Revision
- 241754
- Author
- [email protected]
- Date
- 2019-02-18 19:03:02 -0800 (Mon, 18 Feb 2019)
Log Message
Revert functional part of r241451
https://bugs.webkit.org/show_bug.cgi?id=194510
Source/WebKit:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
It caused crashes and assertions on Linux and Cocoa without safe browsing, which
means it's fundamentally flawed in some way. The testing piping was fine.
LayoutTests:
* platform/wk2/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (241753 => 241754)
--- trunk/LayoutTests/ChangeLog 2019-02-19 02:32:10 UTC (rev 241753)
+++ trunk/LayoutTests/ChangeLog 2019-02-19 03:03:02 UTC (rev 241754)
@@ -1,3 +1,10 @@
+2019-02-18 Alex Christensen <[email protected]>
+
+ Revert functional part of r241451
+ https://bugs.webkit.org/show_bug.cgi?id=194510
+
+ * platform/wk2/TestExpectations:
+
2019-02-18 Daniel Bates <[email protected]>
[iOS] Focus ring for checkboxes, radio buttons, buttons and search fields should hug tighter to the contour
Modified: trunk/LayoutTests/platform/wk2/TestExpectations (241753 => 241754)
--- trunk/LayoutTests/platform/wk2/TestExpectations 2019-02-19 02:32:10 UTC (rev 241753)
+++ trunk/LayoutTests/platform/wk2/TestExpectations 2019-02-19 03:03:02 UTC (rev 241754)
@@ -749,7 +749,7 @@
fast/forms/call-text-did-change-in-text-field-when-typing.html [ Pass ]
-http/tests/adClickAttribution [ Pass ]
+http/tests/adClickAttribution [ Failure ]
### END OF (5) Progressions, expected successes that are expected failures in WebKit1.
########################################
Modified: trunk/Source/WebKit/ChangeLog (241753 => 241754)
--- trunk/Source/WebKit/ChangeLog 2019-02-19 02:32:10 UTC (rev 241753)
+++ trunk/Source/WebKit/ChangeLog 2019-02-19 03:03:02 UTC (rev 241754)
@@ -1,3 +1,13 @@
+2019-02-18 Alex Christensen <[email protected]>
+
+ Revert functional part of r241451
+ https://bugs.webkit.org/show_bug.cgi?id=194510
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
+ It caused crashes and assertions on Linux and Cocoa without safe browsing, which
+ means it's fundamentally flawed in some way. The testing piping was fine.
+
2019-02-18 Chris Dumez <[email protected]>
REGRESSION (PSON): Can't access optumbank.com from myuhc.com
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (241753 => 241754)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-02-19 02:32:10 UTC (rev 241753)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-02-19 03:03:02 UTC (rev 241754)
@@ -4144,15 +4144,8 @@
// FIXME: We should message check that navigationID is not zero here, but it's currently zero for some navigations through the page cache.
RefPtr<API::Navigation> navigation;
- if (frame->isMainFrame() && navigationID) {
+ if (frame->isMainFrame() && navigationID)
navigation = navigationState().navigation(navigationID);
- if (navigation) {
- if (auto& adClickAttribution = navigation->adClickAttribution()) {
- if (adClickAttribution->destination().matches(frame->url()))
- m_process->processPool().sendToNetworkingProcess(Messages::NetworkProcess::StoreAdClickAttribution(m_websiteDataStore->sessionID(), *adClickAttribution));
- }
- }
- }
if (frame->isMainFrame())
m_navigationClient->didFinishDocumentLoad(*this, navigation.get(), m_process->transformHandlesToObjects(userData.object()).get());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
