Title: [241777] trunk/Source/WebKit
- Revision
- 241777
- Author
- [email protected]
- Date
- 2019-02-19 14:49:13 -0800 (Tue, 19 Feb 2019)
Log Message
Remove assertion introduced in r229683
https://bugs.webkit.org/show_bug.cgi?id=194825
<rdar://problem/47628258>
Reviewed by Geoffrey Garen.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
If we reach this code and the form's original Document's Frame has been destroyed,
we have already been told to submit the form so do so, just like we do if the WebPage
has been destroyed. This is a rare edge case having to do with the timing of Frame
destruction and decidePolicyForNavigationAction response, which unfortunately does not
reproduce with a test case unless the timing of IPC is just right.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (241776 => 241777)
--- trunk/Source/WebKit/ChangeLog 2019-02-19 22:42:53 UTC (rev 241776)
+++ trunk/Source/WebKit/ChangeLog 2019-02-19 22:49:13 UTC (rev 241777)
@@ -1,3 +1,19 @@
+2019-02-19 Alex Christensen <[email protected]>
+
+ Remove assertion introduced in r229683
+ https://bugs.webkit.org/show_bug.cgi?id=194825
+ <rdar://problem/47628258>
+
+ Reviewed by Geoffrey Garen.
+
+ * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
+ (WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
+ If we reach this code and the form's original Document's Frame has been destroyed,
+ we have already been told to submit the form so do so, just like we do if the WebPage
+ has been destroyed. This is a rare edge case having to do with the timing of Frame
+ destruction and decidePolicyForNavigationAction response, which unfortunately does not
+ reproduce with a test case unless the timing of IPC is just right.
+
2019-02-19 Antoine Quint <[email protected]>
[iOS] "touch-action: none" should not prevent text selection or tapping on a link
Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp (241776 => 241777)
--- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2019-02-19 22:42:53 UTC (rev 241776)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp 2019-02-19 22:49:13 UTC (rev 241777)
@@ -973,9 +973,11 @@
auto& form = formState.form();
auto* sourceCoreFrame = formState.sourceDocument().frame();
- RELEASE_ASSERT(sourceCoreFrame);
+ if (!sourceCoreFrame)
+ return completionHandler();
auto* sourceFrame = WebFrame::fromCoreFrame(*sourceCoreFrame);
- ASSERT(sourceFrame);
+ if (!sourceFrame)
+ return completionHandler();
auto& values = formState.textFieldValues();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
