Title: [241830] trunk/Source/WebCore
- Revision
- 241830
- Author
- [email protected]
- Date
- 2019-02-20 13:08:44 -0800 (Wed, 20 Feb 2019)
Log Message
REGRESSION (r241788>): ASSERTION FAILED: !m_normalFlowListDirty in TestWebKitAPI.WebKit.ResizeReversePaginatedWebView test
https://bugs.webkit.org/show_bug.cgi?id=194866
Reviewed by Antti Koivisto.
r241788 removed some calls that updated layer lists (normal flow and z-order) during compositing updates, causing
a later call to RenderLayerCompositor::recursiveRepaintLayer() to assert when the lists were dirty. Fix by updating
the lists in RenderLayerCompositor::recursiveRepaintLayer(), as we do in various other places.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::recursiveRepaintLayer):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (241829 => 241830)
--- trunk/Source/WebCore/ChangeLog 2019-02-20 20:27:13 UTC (rev 241829)
+++ trunk/Source/WebCore/ChangeLog 2019-02-20 21:08:44 UTC (rev 241830)
@@ -1,3 +1,17 @@
+2019-02-20 Simon Fraser <[email protected]>
+
+ REGRESSION (r241788>): ASSERTION FAILED: !m_normalFlowListDirty in TestWebKitAPI.WebKit.ResizeReversePaginatedWebView test
+ https://bugs.webkit.org/show_bug.cgi?id=194866
+
+ Reviewed by Antti Koivisto.
+
+ r241788 removed some calls that updated layer lists (normal flow and z-order) during compositing updates, causing
+ a later call to RenderLayerCompositor::recursiveRepaintLayer() to assert when the lists were dirty. Fix by updating
+ the lists in RenderLayerCompositor::recursiveRepaintLayer(), as we do in various other places.
+
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::recursiveRepaintLayer):
+
2019-02-20 Daniel Bates <[email protected]>
[iOS] Tweak UI for focus rings
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (241829 => 241830)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2019-02-20 20:27:13 UTC (rev 241829)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2019-02-20 21:08:44 UTC (rev 241830)
@@ -1991,6 +1991,8 @@
void RenderLayerCompositor::recursiveRepaintLayer(RenderLayer& layer)
{
+ layer.updateLayerListsIfNeeded();
+
// FIXME: This method does not work correctly with transforms.
if (layer.isComposited() && !layer.backing()->paintsIntoCompositedAncestor())
layer.setBackingNeedsRepaint();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
