Title: [241953] trunk/Source/WebInspectorUI
- Revision
- 241953
- Author
- [email protected]
- Date
- 2019-02-22 10:46:29 -0800 (Fri, 22 Feb 2019)
Log Message
Web Inspector: Remove unused Timeline record selection code path
https://bugs.webkit.org/show_bug.cgi?id=194931
Patch by Joseph Pecoraro <[email protected]> on 2019-02-22
Reviewed by Devin Rousso.
* UserInterface/Views/TimelineOverview.js:
(WI.TimelineOverview):
(WI.TimelineOverview.prototype.userSelectedRecord): Deleted.
* UserInterface/Views/TimelineRecordingContentView.js:
(WI.TimelineRecordingContentView):
(WI.TimelineRecordingContentView.prototype.timelineOverviewUserSelectedRecord): Deleted.
* UserInterface/Views/TimelineView.js:
(WI.TimelineView.prototype.userSelectedRecordFromOverview): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (241952 => 241953)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-02-22 18:46:25 UTC (rev 241952)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-02-22 18:46:29 UTC (rev 241953)
@@ -1,3 +1,19 @@
+2019-02-22 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Remove unused Timeline record selection code path
+ https://bugs.webkit.org/show_bug.cgi?id=194931
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/TimelineOverview.js:
+ (WI.TimelineOverview):
+ (WI.TimelineOverview.prototype.userSelectedRecord): Deleted.
+ * UserInterface/Views/TimelineRecordingContentView.js:
+ (WI.TimelineRecordingContentView):
+ (WI.TimelineRecordingContentView.prototype.timelineOverviewUserSelectedRecord): Deleted.
+ * UserInterface/Views/TimelineView.js:
+ (WI.TimelineView.prototype.userSelectedRecordFromOverview): Deleted.
+
2019-02-21 Darin Adler <[email protected]>
Some refinements for Node and Document
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js (241952 => 241953)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js 2019-02-22 18:46:25 UTC (rev 241952)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js 2019-02-22 18:46:29 UTC (rev 241953)
@@ -25,7 +25,7 @@
WI.TimelineOverview = class TimelineOverview extends WI.View
{
- constructor(timelineRecording, delegate)
+ constructor(timelineRecording)
{
super();
@@ -46,8 +46,6 @@
this._recording.addEventListener(WI.TimelineRecording.Event.MarkerAdded, this._markerAdded, this);
this._recording.addEventListener(WI.TimelineRecording.Event.Reset, this._recordingReset, this);
- this._delegate = delegate;
-
this.element.classList.add("timeline-overview");
this._updateWheelAndGestureHandlers();
@@ -411,12 +409,6 @@
overviewGraph.selectedRecord = record;
}
- userSelectedRecord(record)
- {
- if (this._delegate && this._delegate.timelineOverviewUserSelectedRecord)
- this._delegate.timelineOverviewUserSelectedRecord(this, record);
- }
-
updateLayoutIfNeeded(layoutReason)
{
if (this.layoutPending) {
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js (241952 => 241953)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2019-02-22 18:46:25 UTC (rev 241952)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2019-02-22 18:46:29 UTC (rev 241953)
@@ -34,7 +34,7 @@
this.element.classList.add("timeline-recording");
- this._timelineOverview = new WI.TimelineOverview(this._recording, this);
+ this._timelineOverview = new WI.TimelineOverview(this._recording);
this._timelineOverview.addEventListener(WI.TimelineOverview.Event.TimeRangeSelectionChanged, this._timeRangeSelectionChanged, this);
this._timelineOverview.addEventListener(WI.TimelineOverview.Event.RecordSelected, this._recordSelected, this);
this._timelineOverview.addEventListener(WI.TimelineOverview.Event.TimelineSelected, this._timelineSelected, this);
@@ -262,25 +262,6 @@
return new WI.GeneralTreeElement(iconClassName, title, representedObject, hasChildren);
}
- // TimelineOverview delegate
-
- timelineOverviewUserSelectedRecord(timelineOverview, timelineRecord)
- {
- let timelineViewForRecord = null;
- for (let timelineView of this._timelineViewMap.values()) {
- if (timelineView.representedObject.type === timelineRecord.type) {
- timelineViewForRecord = timelineView;
- break;
- }
- }
-
- if (!timelineViewForRecord)
- return;
-
- this._timelineContentBrowser.showContentView(timelineViewForRecord);
- timelineViewForRecord.userSelectedRecordFromOverview(timelineRecord);
- }
-
// Private
_currentContentViewDidChange(event)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js (241952 => 241953)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js 2019-02-22 18:46:25 UTC (rev 241952)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineView.js 2019-02-22 18:46:29 UTC (rev 241953)
@@ -295,11 +295,6 @@
// Protected
- userSelectedRecordFromOverview(timelineRecord)
- {
- // Implemented by sub-classes if needed.
- }
-
filterDidChange()
{
// Implemented by sub-classes if needed.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
