Title: [242057] trunk/Source/WebInspectorUI
- Revision
- 242057
- Author
- [email protected]
- Date
- 2019-02-25 14:22:56 -0800 (Mon, 25 Feb 2019)
Log Message
Web Inspector: REGRESSION: TreeElement or Table row selected using the keyboard should always be revealed
https://bugs.webkit.org/show_bug.cgi?id=194918
<rdar://problem/48289314>
Reviewed by Devin Rousso.
* UserInterface/Views/Table.js:
(WI.Table.prototype.selectionControllerSelectionDidChange):
* UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype._treeKeyDown):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (242056 => 242057)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-02-25 21:52:56 UTC (rev 242056)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-02-25 22:22:56 UTC (rev 242057)
@@ -1,3 +1,17 @@
+2019-02-25 Matt Baker <[email protected]>
+
+ Web Inspector: REGRESSION: TreeElement or Table row selected using the keyboard should always be revealed
+ https://bugs.webkit.org/show_bug.cgi?id=194918
+ <rdar://problem/48289314>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/Table.js:
+ (WI.Table.prototype.selectionControllerSelectionDidChange):
+
+ * UserInterface/Views/TreeOutline.js:
+ (WI.TreeOutline.prototype._treeKeyDown):
+
2019-02-25 Devin Rousso <[email protected]>
Web Inspector: [META] Merge Resources and Debugger into a single Sources tab
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Table.js (242056 => 242057)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Table.js 2019-02-25 21:52:56 UTC (rev 242056)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Table.js 2019-02-25 22:22:56 UTC (rev 242057)
@@ -619,10 +619,9 @@
row.classList.toggle("selected", true);
}
- if (selectedItems.size === 1) {
- let rowIndex = this._indexForRepresentedObject(selectedItems.firstValue);
- if (!this._isRowVisible(rowIndex))
- this.revealRow(rowIndex);
+ if (this._selectionController.lastSelectedItem) {
+ let rowIndex = this._indexForRepresentedObject(this._selectionController.lastSelectedItem);
+ this.revealRow(rowIndex);
}
if (this._delegate.tableSelectionDidChange)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (242056 => 242057)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2019-02-25 21:52:56 UTC (rev 242056)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2019-02-25 22:22:56 UTC (rev 242057)
@@ -661,6 +661,9 @@
this._itemWasSelectedByUser = true;
handled = this._selectionController.handleKeyDown(event);
this._itemWasSelectedByUser = false;
+
+ if (handled)
+ nextSelectedElement = this.selectedTreeElement;
}
if (nextSelectedElement) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
