Title: [242120] trunk/JSTests
- Revision
- 242120
- Author
- [email protected]
- Date
- 2019-02-26 19:48:25 -0800 (Tue, 26 Feb 2019)
Log Message
REGRESSION: stress/regress-178386.js is timing out on JSC debug bot
https://bugs.webkit.org/show_bug.cgi?id=194677
<rdar://problem/48112492>
Reviewed by Mark Lam.
Before r241233, String.fromCharCode (except for an empty string) always returns 16bit string.
This makes the rope generated by padEnd 16bit. When we resolve the rope inside JSON.stringify,
it immediately fails due the large size.
After r241233, String.fromCharCode starts returning 8bit string if possible. So the rope becomes
8bit, and we successfully resolve the rope in this case. Resolving such a large rope takes long
time and that is why stress/regress-178386.js starts timing out. Note that, the test fails with
OOM error anyway because JSON.stringify's builder overflows with such a large string input.
This patch changes the test to produce 16bit string from String.fromCharCode.
* stress/regress-178386.js:
Modified Paths
Diff
Modified: trunk/JSTests/ChangeLog (242119 => 242120)
--- trunk/JSTests/ChangeLog 2019-02-27 01:33:08 UTC (rev 242119)
+++ trunk/JSTests/ChangeLog 2019-02-27 03:48:25 UTC (rev 242120)
@@ -1,3 +1,24 @@
+2019-02-26 Yusuke Suzuki <[email protected]>
+
+ REGRESSION: stress/regress-178386.js is timing out on JSC debug bot
+ https://bugs.webkit.org/show_bug.cgi?id=194677
+ <rdar://problem/48112492>
+
+ Reviewed by Mark Lam.
+
+ Before r241233, String.fromCharCode (except for an empty string) always returns 16bit string.
+ This makes the rope generated by padEnd 16bit. When we resolve the rope inside JSON.stringify,
+ it immediately fails due the large size.
+
+ After r241233, String.fromCharCode starts returning 8bit string if possible. So the rope becomes
+ 8bit, and we successfully resolve the rope in this case. Resolving such a large rope takes long
+ time and that is why stress/regress-178386.js starts timing out. Note that, the test fails with
+ OOM error anyway because JSON.stringify's builder overflows with such a large string input.
+
+ This patch changes the test to produce 16bit string from String.fromCharCode.
+
+ * stress/regress-178386.js:
+
2019-02-26 Mark Lam <[email protected]>
wasmToJS() should purify incoming NaNs.
Modified: trunk/JSTests/stress/regress-178386.js (242119 => 242120)
--- trunk/JSTests/stress/regress-178386.js 2019-02-27 01:33:08 UTC (rev 242119)
+++ trunk/JSTests/stress/regress-178386.js 2019-02-27 03:48:25 UTC (rev 242120)
@@ -1,4 +1,4 @@
-var str1 = String.fromCharCode(136, 115, 29, 20, 15, 155, 81);
+var str1 = String.fromCharCode(365, 115, 29, 20, 15, 155, 81);
str3 = str1.padEnd(0x7FFFFFFC, '123');
var exception;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
