Title: [242144] trunk/Source/WebInspectorUI
- Revision
- 242144
- Author
- [email protected]
- Date
- 2019-02-27 12:13:14 -0800 (Wed, 27 Feb 2019)
Log Message
Web Inspector: popover colors don't change when transitioning to/from dark mode
https://bugs.webkit.org/show_bug.cgi?id=195113
<rdar://problem/48444188>
Reviewed by Timothy Hatcher.
* UserInterface/Views/Popover.js:
(WI.Popover.prototype.dismiss):
(WI.Popover.prototype._addListenersIfNeeded):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (242143 => 242144)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-02-27 20:11:23 UTC (rev 242143)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-02-27 20:13:14 UTC (rev 242144)
@@ -1,3 +1,15 @@
+2019-02-27 Devin Rousso <[email protected]>
+
+ Web Inspector: popover colors don't change when transitioning to/from dark mode
+ https://bugs.webkit.org/show_bug.cgi?id=195113
+ <rdar://problem/48444188>
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/Popover.js:
+ (WI.Popover.prototype.dismiss):
+ (WI.Popover.prototype._addListenersIfNeeded):
+
2019-02-26 Matt Baker <[email protected]>
Web Inspector: Use system accent color throughout UI
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Popover.js (242143 => 242144)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Popover.js 2019-02-27 20:11:23 UTC (rev 242143)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Popover.js 2019-02-27 20:13:14 UTC (rev 242144)
@@ -156,6 +156,8 @@
window.removeEventListener("resize", this, true);
window.removeEventListener("keypress", this, true);
+ this._prefersDarkColorSchemeMediaQueryList.removeListener(this._boundUpdate);
+
WI.quickConsole.keyboardShortcutDisabled = false;
this._element.classList.add(WI.Popover.FadeOutClassName);
@@ -578,6 +580,13 @@
window.addEventListener("resize", this, true);
window.addEventListener("keypress", this, true);
+ if (!this._boundUpdate)
+ this._boundUpdate = this._update.bind(this);
+
+ if (!this._prefersDarkColorSchemeMediaQueryList)
+ this._prefersDarkColorSchemeMediaQueryList = window.matchMedia("(prefers-color-scheme: dark)");
+ this._prefersDarkColorSchemeMediaQueryList.addListener(this._boundUpdate);
+
WI.quickConsole.keyboardShortcutDisabled = true;
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
