Title: [242197] trunk/Source/WebInspectorUI
- Revision
- 242197
- Author
- commit-qu...@webkit.org
- Date
- 2019-02-28 01:02:43 -0800 (Thu, 28 Feb 2019)
Log Message
Web Inspector: Revert -webkit-border-end changes that are unreliable
https://bugs.webkit.org/show_bug.cgi?id=195149
Patch by Joseph Pecoraro <pecor...@apple.com> on 2019-02-28
Reviewed by Matt Baker.
* UserInterface/Views/CPUUsageIndicatorView.css:
(.cpu-usage-indicator-view > .details):
(body[dir=ltr] .cpu-usage-indicator-view > .details):
(body[dir=rtl] .cpu-usage-indicator-view > .details):
* UserInterface/Views/CPUUsageStackedView.css:
(.cpu-usage-stacked-view > .details):
(body[dir=ltr] .cpu-usage-stacked-view > .details):
(body[dir=rtl] .cpu-usage-stacked-view > .details):
* UserInterface/Views/CPUUsageView.css:
(.cpu-usage-view > .details):
(body[dir=ltr] .cpu-usage-view > .details):
(body[dir=rtl] .cpu-usage-view > .details):
* UserInterface/Views/MemoryCategoryView.css:
(.memory-category-view > .details):
(body[dir=ltr] .memory-category-view > .details):
(body[dir=rtl] .memory-category-view > .details):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (242196 => 242197)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-02-28 08:27:37 UTC (rev 242196)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-02-28 09:02:43 UTC (rev 242197)
@@ -1,5 +1,29 @@
2019-02-28 Joseph Pecoraro <pecor...@apple.com>
+ Web Inspector: Revert -webkit-border-end changes that are unreliable
+ https://bugs.webkit.org/show_bug.cgi?id=195149
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Views/CPUUsageIndicatorView.css:
+ (.cpu-usage-indicator-view > .details):
+ (body[dir=ltr] .cpu-usage-indicator-view > .details):
+ (body[dir=rtl] .cpu-usage-indicator-view > .details):
+ * UserInterface/Views/CPUUsageStackedView.css:
+ (.cpu-usage-stacked-view > .details):
+ (body[dir=ltr] .cpu-usage-stacked-view > .details):
+ (body[dir=rtl] .cpu-usage-stacked-view > .details):
+ * UserInterface/Views/CPUUsageView.css:
+ (.cpu-usage-view > .details):
+ (body[dir=ltr] .cpu-usage-view > .details):
+ (body[dir=rtl] .cpu-usage-view > .details):
+ * UserInterface/Views/MemoryCategoryView.css:
+ (.memory-category-view > .details):
+ (body[dir=ltr] .memory-category-view > .details):
+ (body[dir=rtl] .memory-category-view > .details):
+
+2019-02-28 Joseph Pecoraro <pecor...@apple.com>
+
Web Inspector: Cleanup some Chart code
https://bugs.webkit.org/show_bug.cgi?id=195147
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CPUUsageIndicatorView.css (242196 => 242197)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CPUUsageIndicatorView.css 2019-02-28 08:27:37 UTC (rev 242196)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CPUUsageIndicatorView.css 2019-02-28 09:02:43 UTC (rev 242197)
@@ -34,9 +34,18 @@
flex-shrink: 0;
width: 150px;
-webkit-padding-start: 15px;
- -webkit-border-end: 1px solid var(--border-color);
+
+ --cpu-usage-indicator-view-details-border-end: 1px solid var(--border-color);
}
+body[dir=ltr] .cpu-usage-indicator-view > .details {
+ border-right: var(--cpu-usage-indicator-view-details-border-end);
+}
+
+body[dir=rtl] .cpu-usage-indicator-view > .details {
+ border-left: var(--cpu-usage-indicator-view-details-border-end);
+}
+
body[dir=rtl] .cpu-usage-indicator-view > .graph {
transform: scaleX(-1);
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CPUUsageStackedView.css (242196 => 242197)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CPUUsageStackedView.css 2019-02-28 08:27:37 UTC (rev 242196)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CPUUsageStackedView.css 2019-02-28 09:02:43 UTC (rev 242197)
@@ -40,9 +40,18 @@
color: var(--text-color-secondary);
overflow: hidden;
text-overflow: ellipsis;
- -webkit-border-end: 1px solid var(--border-color);
+
+ --cpu-usage-stacked-view-details-border-end: 1px solid var(--border-color);
}
+body[dir=ltr] .cpu-usage-stacked-view > .details {
+ border-right: var(--cpu-usage-stacked-view-details-border-end);
+}
+
+body[dir=rtl] .cpu-usage-stacked-view > .details {
+ border-left: var(--cpu-usage-stacked-view-details-border-end);
+}
+
.cpu-usage-stacked-view > .details > .name {
color: var(--text-color);
white-space: nowrap;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CPUUsageView.css (242196 => 242197)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CPUUsageView.css 2019-02-28 08:27:37 UTC (rev 242196)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CPUUsageView.css 2019-02-28 09:02:43 UTC (rev 242197)
@@ -40,9 +40,18 @@
color: var(--text-color-secondary);
overflow: hidden;
text-overflow: ellipsis;
- -webkit-border-end: 1px solid var(--border-color);
+
+ --cpu-usage-view-details-border-end: 1px solid var(--border-color);
}
+body[dir=ltr] .cpu-usage-view > .details {
+ border-right: var(--cpu-usage-view-details-border-end);
+}
+
+body[dir=rtl] .cpu-usage-view > .details {
+ border-left: var(--cpu-usage-view-details-border-end);
+}
+
.cpu-usage-view > .details > .name {
color: var(--text-color);
white-space: nowrap;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/MemoryCategoryView.css (242196 => 242197)
--- trunk/Source/WebInspectorUI/UserInterface/Views/MemoryCategoryView.css 2019-02-28 08:27:37 UTC (rev 242196)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/MemoryCategoryView.css 2019-02-28 09:02:43 UTC (rev 242197)
@@ -40,9 +40,18 @@
color: var(--text-color-secondary);
overflow: hidden;
text-overflow: ellipsis;
- -webkit-border-end: 1px solid var(--border-color);
+
+ --memory-category-view-details-border-end: 1px solid var(--border-color);
}
+body[dir=ltr] .memory-category-view > .details {
+ border-right: var(--memory-category-view-details-border-end);
+}
+
+body[dir=rtl] .memory-category-view > .details {
+ border-left: var(--memory-category-view-details-border-end);
+}
+
.memory-category-view > .details > .name {
color: var(--text-color);
white-space: nowrap;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
