Title: [242217] trunk/Source/WebInspectorUI
- Revision
- 242217
- Author
- [email protected]
- Date
- 2019-02-28 13:06:59 -0800 (Thu, 28 Feb 2019)
Log Message
Web Inspector: Canvas: enabling auto-capture if the frame count is empty triggers an assertion
https://bugs.webkit.org/show_bug.cgi?id=195060
Reviewed by Matt Baker.
* UserInterface/Views/CanvasOverviewContentView.js:
(WI.CanvasOverviewContentView.prototype._setRecordingAutoCaptureFrameCount):
(WI.CanvasOverviewContentView.prototype._updateRecordingAutoCaptureCheckboxLabel):
(WI.CanvasOverviewContentView.prototype._handleRecordingAutoCaptureCheckedDidChange):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (242216 => 242217)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-02-28 20:52:49 UTC (rev 242216)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-02-28 21:06:59 UTC (rev 242217)
@@ -1,3 +1,15 @@
+2019-02-28 Devin Rousso <[email protected]>
+
+ Web Inspector: Canvas: enabling auto-capture if the frame count is empty triggers an assertion
+ https://bugs.webkit.org/show_bug.cgi?id=195060
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Views/CanvasOverviewContentView.js:
+ (WI.CanvasOverviewContentView.prototype._setRecordingAutoCaptureFrameCount):
+ (WI.CanvasOverviewContentView.prototype._updateRecordingAutoCaptureCheckboxLabel):
+ (WI.CanvasOverviewContentView.prototype._handleRecordingAutoCaptureCheckedDidChange):
+
2019-02-28 Joseph Pecoraro <[email protected]>
Web Inspector: Revert -webkit-border-end changes that are unreliable
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js (242216 => 242217)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js 2019-02-28 20:52:49 UTC (rev 242216)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.js 2019-02-28 21:06:59 UTC (rev 242217)
@@ -189,9 +189,6 @@
_setRecordingAutoCaptureFrameCount(frameCount)
{
- if (isNaN(frameCount))
- frameCount = this._recordingAutoCaptureFrameCountInputElementValue;
-
console.assert(!isNaN(frameCount) && frameCount >= 0);
if (this._recordingAutoCaptureNavigationItem.checked)
@@ -204,22 +201,17 @@
_updateRecordingAutoCaptureCheckboxLabel(frameCount)
{
- if (isNaN(frameCount))
- frameCount = this._recordingAutoCaptureFrameCountInputElementValue;
-
- let label = frameCount === 1 ? WI.UIString("Record first %s frame") : WI.UIString("Record first %s frames");
-
let active = document.activeElement === this._recordingAutoCaptureFrameCountInputElement;
let selectionStart = this._recordingAutoCaptureFrameCountInputElement.selectionStart;
let selectionEnd = this._recordingAutoCaptureFrameCountInputElement.selectionEnd;
let direction = this._recordingAutoCaptureFrameCountInputElement.direction;
+ let label = frameCount === 1 ? WI.UIString("Record first %s frame") : WI.UIString("Record first %s frames");
let fragment = document.createDocumentFragment();
String.format(label, [this._recordingAutoCaptureFrameCountInputElement], String.standardFormatters, fragment, (a, b) => {
a.append(b);
return a;
});
-
this._recordingAutoCaptureNavigationItem.label = fragment;
if (active) {
@@ -276,7 +268,7 @@
_handleRecordingAutoCaptureCheckedDidChange(event)
{
- this._setRecordingAutoCaptureFrameCount();
+ this._setRecordingAutoCaptureFrameCount(this._recordingAutoCaptureFrameCountInputElementValue || 0);
}
_handleCanvasRecordingAutoCaptureEnabledChanged(event)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
