Title: [242314] trunk/Source/WebInspectorUI
- Revision
- 242314
- Author
- [email protected]
- Date
- 2019-03-02 12:32:11 -0800 (Sat, 02 Mar 2019)
Log Message
Web Inspector: Debugger: don't enable breakpoints when source location changes
https://bugs.webkit.org/show_bug.cgi?id=195081
<rdar://problem/48422701>
Reviewed by Joseph Pecoraro.
* UserInterface/Controllers/DebuggerManager.js:
(WI.DebuggerManager.prototype._breakpointDisplayLocationDidChange):
(WI.DebuggerManager.prototype._breakpointEditablePropertyDidChange):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (242313 => 242314)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-03-02 19:15:21 UTC (rev 242313)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-03-02 20:32:11 UTC (rev 242314)
@@ -1,3 +1,15 @@
+2019-03-02 Devin Rousso <[email protected]>
+
+ Web Inspector: Debugger: don't enable breakpoints when source location changes
+ https://bugs.webkit.org/show_bug.cgi?id=195081
+ <rdar://problem/48422701>
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Controllers/DebuggerManager.js:
+ (WI.DebuggerManager.prototype._breakpointDisplayLocationDidChange):
+ (WI.DebuggerManager.prototype._breakpointEditablePropertyDidChange):
+
2019-03-01 Joseph Pecoraro <[email protected]>
Web Inspector: CPU Usage - Energy Impact Section
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js (242313 => 242314)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js 2019-03-02 19:15:21 UTC (rev 242313)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js 2019-03-02 20:32:11 UTC (rev 242314)
@@ -1034,15 +1034,14 @@
return;
// Remove the breakpoint with its old id.
- this._removeBreakpoint(breakpoint, breakpointRemoved.bind(this));
-
- function breakpointRemoved()
- {
+ this._removeBreakpoint(breakpoint, () => {
// Add the breakpoint at its new lineNumber and get a new id.
+ this._restoringBreakpoints = true;
this._setBreakpoint(breakpoint);
+ this._restoringBreakpoints = false;
this.dispatchEventToListeners(WI.DebuggerManager.Event.BreakpointMoved, {breakpoint});
- }
+ });
}
_breakpointDisabledStateDidChange(event)
@@ -1098,13 +1097,12 @@
return;
// Remove the breakpoint with its old id.
- this._removeBreakpoint(breakpoint, breakpointRemoved.bind(this));
-
- function breakpointRemoved()
- {
+ this._removeBreakpoint(breakpoint, () => {
// Add the breakpoint with its new properties and get a new id.
+ this._restoringBreakpoints = true;
this._setBreakpoint(breakpoint);
- }
+ this._restoringBreakpoints = false;
+ });
}
_handleBreakpointActionsDidChange(event)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
