Title: [242370] trunk/Source/WebInspectorUI
- Revision
- 242370
- Author
- [email protected]
- Date
- 2019-03-04 12:23:49 -0800 (Mon, 04 Mar 2019)
Log Message
Web Inspector: Toggling Timeline "Stop when page loads" to on should stop (immediately or soon) any active recording if already past the load event
https://bugs.webkit.org/show_bug.cgi?id=195239
Reviewed by Joseph Pecoraro.
* UserInterface/Controllers/TimelineManager.js:
(WI.TimelineManager.prototype._handleTimelinesAutoStopSettingChanged):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (242369 => 242370)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-03-04 20:20:59 UTC (rev 242369)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-03-04 20:23:49 UTC (rev 242370)
@@ -1,3 +1,13 @@
+2019-03-04 Devin Rousso <[email protected]>
+
+ Web Inspector: Toggling Timeline "Stop when page loads" to on should stop (immediately or soon) any active recording if already past the load event
+ https://bugs.webkit.org/show_bug.cgi?id=195239
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Controllers/TimelineManager.js:
+ (WI.TimelineManager.prototype._handleTimelinesAutoStopSettingChanged):
+
2019-03-02 Devin Rousso <[email protected]>
Web Inspector: Unexpectedly frequent flashing of DOM node attributes
Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js (242369 => 242370)
--- trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js 2019-03-04 20:20:59 UTC (rev 242369)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js 2019-03-04 20:23:49 UTC (rev 242370)
@@ -956,9 +956,13 @@
if (!this._isCapturing)
return;
- if (WI.settings.timelinesAutoStop.value)
- this._resetAutoRecordingMaxTimeTimeout();
- else
+ if (WI.settings.timelinesAutoStop.value) {
+ if (this._mainResourceForAutoCapturing && !isNaN(this._mainResourceForAutoCapturing.parentFrame.loadEventTimestamp))
+ this._stopAutoRecordingSoon();
+ else
+ this._resetAutoRecordingMaxTimeTimeout();
+ this._resetAutoRecordingDeadTimeTimeout();
+ } else
this.relaxAutoStop();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
