Title: [242376] trunk/Source/WebKit
Revision
242376
Author
[email protected]
Date
2019-03-04 12:39:33 -0800 (Mon, 04 Mar 2019)

Log Message

Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
<rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291

Reviewed by Andy Estes.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::shouldReuseCommittedSandboxExtension): Only retain the previous sandbox extension if the file URL
  we're currently loading is functionally equivalent to the previous one.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (242375 => 242376)


--- trunk/Source/WebKit/ChangeLog	2019-03-04 20:36:32 UTC (rev 242375)
+++ trunk/Source/WebKit/ChangeLog	2019-03-04 20:39:33 UTC (rev 242376)
@@ -1,3 +1,14 @@
+2019-03-04  Brady Eidson  <[email protected]>
+
+        Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
+        <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
+
+        Reviewed by Andy Estes.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::shouldReuseCommittedSandboxExtension): Only retain the previous sandbox extension if the file URL
+          we're currently loading is functionally equivalent to the previous one.
+
 2019-03-04  Chris Dumez  <[email protected]>
 
         Drop legacy userAgentForURL injected bundle SPI

Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (242375 => 242376)


--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2019-03-04 20:36:32 UTC (rev 242375)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp	2019-03-04 20:39:33 UTC (rev 242376)
@@ -4412,7 +4412,7 @@
     if (!documentLoader || !provisionalDocumentLoader)
         return false;
 
-    if (documentLoader->url().isLocalFile() && provisionalDocumentLoader->url().isLocalFile())
+    if (documentLoader->url().isLocalFile() && provisionalDocumentLoader->url().isLocalFile() && equalIgnoringQueryAndFragment(documentLoader->url(), provisionalDocumentLoader->url()))
         return true;
 
     return false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to