Title: [242398] trunk/Source/WebKit
- Revision
- 242398
- Author
- [email protected]
- Date
- 2019-03-04 15:49:58 -0800 (Mon, 04 Mar 2019)
Log Message
Unreviewed, a followup after r242336
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::webViewDidMoveToWindow):
Copy the list of observers before iterating it to avoid observers modifying the list.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (242397 => 242398)
--- trunk/Source/WebKit/ChangeLog 2019-03-04 23:27:43 UTC (rev 242397)
+++ trunk/Source/WebKit/ChangeLog 2019-03-04 23:49:58 UTC (rev 242398)
@@ -1,3 +1,11 @@
+2019-03-04 Jiewen Tan <[email protected]>
+
+ Unreviewed, a followup after r242336
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::webViewDidMoveToWindow):
+ Copy the list of observers before iterating it to avoid observers modifying the list.
+
2019-03-04 Truitt Savell <[email protected]>
Unreviewed, rolling out r242222.
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (242397 => 242398)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-03-04 23:27:43 UTC (rev 242397)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2019-03-04 23:49:58 UTC (rev 242398)
@@ -8795,7 +8795,8 @@
void WebPageProxy::webViewDidMoveToWindow()
{
- for (const auto& observer : m_webViewDidMoveToWindowObservers) {
+ auto observersCopy = m_webViewDidMoveToWindowObservers;
+ for (const auto& observer : observersCopy) {
if (!observer.value)
continue;
observer.value->webViewDidMoveToWindow();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
