Title: [242563] branches/safari-607.1.40.0-branch/Source/WebKit
- Revision
- 242563
- Author
- [email protected]
- Date
- 2019-03-06 12:45:54 -0800 (Wed, 06 Mar 2019)
Log Message
Cherry-pick r242554. rdar://problem/48647488
REGRESSION (r238490): YouTube.com: Returning PiP to Safari after sleeping device loses page
https://bugs.webkit.org/show_bug.cgi?id=195364
<rdar://problem/48538837>
Reviewed by Geoffrey Garen.
Make sure we unset the LayerTreeFreezeReason::ProcessSuspended layer tree freeze reason
when WebPage::applicationWillEnterForeground() is called. This restores pre-r238490
behavior and addresses the issue with PiP on youtube.com.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::applicationWillEnterForeground):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-607.1.40.0-branch/Source/WebKit/ChangeLog (242562 => 242563)
--- branches/safari-607.1.40.0-branch/Source/WebKit/ChangeLog 2019-03-06 20:38:43 UTC (rev 242562)
+++ branches/safari-607.1.40.0-branch/Source/WebKit/ChangeLog 2019-03-06 20:45:54 UTC (rev 242563)
@@ -1,3 +1,38 @@
+2019-03-06 Kocsen Chung <[email protected]>
+
+ Cherry-pick r242554. rdar://problem/48538837
+
+ REGRESSION (r238490): YouTube.com: Returning PiP to Safari after sleeping device loses page
+ https://bugs.webkit.org/show_bug.cgi?id=195364
+ <rdar://problem/48538837>
+
+ Reviewed by Geoffrey Garen.
+
+ Make sure we unset the LayerTreeFreezeReason::ProcessSuspended layer tree freeze reason
+ when WebPage::applicationWillEnterForeground() is called. This restores pre-r238490
+ behavior and addresses the issue with PiP on youtube.com.
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::applicationWillEnterForeground):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2019-03-06 Chris Dumez <[email protected]>
+
+ REGRESSION (r238490): YouTube.com: Returning PiP to Safari after sleeping device loses page
+ https://bugs.webkit.org/show_bug.cgi?id=195364
+ <rdar://problem/48538837>
+
+ Reviewed by Geoffrey Garen.
+
+ Make sure we unset the LayerTreeFreezeReason::ProcessSuspended layer tree freeze reason
+ when WebPage::applicationWillEnterForeground() is called. This restores pre-r238490
+ behavior and addresses the issue with PiP on youtube.com.
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::applicationWillEnterForeground):
+
2019-03-05 Kocsen Chung <[email protected]>
Cherry-pick r242394. rdar://problem/48591281
Modified: branches/safari-607.1.40.0-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (242562 => 242563)
--- branches/safari-607.1.40.0-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2019-03-06 20:38:43 UTC (rev 242562)
+++ branches/safari-607.1.40.0-branch/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2019-03-06 20:45:54 UTC (rev 242563)
@@ -2896,6 +2896,9 @@
{
m_isSuspendedUnderLock = false;
cancelMarkLayersVolatile();
+
+ // FIXME: In iOS, we sometimes never unset ProcessSuspended. See <rdar://problem/48538837>.
+ unfreezeLayerTree(LayerTreeFreezeReason::ProcessSuspended);
unfreezeLayerTree(LayerTreeFreezeReason::BackgroundApplication);
[[NSNotificationCenter defaultCenter] postNotificationName:WebUIApplicationWillEnterForegroundNotification object:nil userInfo:@{@"isSuspendedUnderLock": @(isSuspendedUnderLock)}];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
