Title: [242655] trunk/Source/_javascript_Core
- Revision
- 242655
- Author
- [email protected]
- Date
- 2019-03-08 13:59:34 -0800 (Fri, 08 Mar 2019)
Log Message
Unreviewed, follow-up after r242568
Robin pointed that calculation of `numberOfChildren` and `nonEmptyIndex` is unnecessary.
* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (242654 => 242655)
--- trunk/Source/_javascript_Core/ChangeLog 2019-03-08 21:11:41 UTC (rev 242654)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-03-08 21:59:34 UTC (rev 242655)
@@ -1,5 +1,14 @@
2019-03-08 Yusuke Suzuki <[email protected]>
+ Unreviewed, follow-up after r242568
+
+ Robin pointed that calculation of `numberOfChildren` and `nonEmptyIndex` is unnecessary.
+
+ * dfg/DFGAbstractInterpreterInlines.h:
+ (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
+
+2019-03-08 Yusuke Suzuki <[email protected]>
+
[JSC] We should have more WithoutTransition functions which are usable for JSGlobalObject initialization
https://bugs.webkit.org/show_bug.cgi?id=195447
Modified: trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h (242654 => 242655)
--- trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h 2019-03-08 21:11:41 UTC (rev 242654)
+++ trunk/Source/_javascript_Core/dfg/DFGAbstractInterpreterInlines.h 2019-03-08 21:59:34 UTC (rev 242655)
@@ -707,29 +707,18 @@
}
case MakeRope: {
- unsigned numberOfChildren = 0;
unsigned numberOfRemovedChildren = 0;
- Optional<unsigned> nonEmptyIndex;
for (unsigned i = 0; i < AdjacencyList::Size; ++i) {
Edge& edge = node->children.child(i);
if (!edge)
break;
- ++numberOfChildren;
-
JSValue childConstant = m_state.forNode(edge).value();
- if (!childConstant) {
- nonEmptyIndex = i;
+ if (!childConstant)
continue;
- }
- if (!childConstant.isString()) {
- nonEmptyIndex = i;
+ if (!childConstant.isString())
continue;
- }
- if (asString(childConstant)->length()) {
- nonEmptyIndex = i;
+ if (asString(childConstant)->length())
continue;
- }
-
++numberOfRemovedChildren;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
