Title: [242659] trunk/Source/_javascript_Core
- Revision
- 242659
- Author
- [email protected]
- Date
- 2019-03-08 15:24:25 -0800 (Fri, 08 Mar 2019)
Log Message
GetByIdStatus can be shrunk by 16 bytes
https://bugs.webkit.org/show_bug.cgi?id=195480
Reviewed by Saam Barati.
8 bytes from reordering fields
8 more bytes by making the enum State only use 1 byte.
* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::GetByIdStatus):
* bytecode/GetByIdStatus.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (242658 => 242659)
--- trunk/Source/_javascript_Core/ChangeLog 2019-03-08 23:20:15 UTC (rev 242658)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-03-08 23:24:25 UTC (rev 242659)
@@ -1,5 +1,19 @@
2019-03-08 Robin Morisset <[email protected]>
+ GetByIdStatus can be shrunk by 16 bytes
+ https://bugs.webkit.org/show_bug.cgi?id=195480
+
+ Reviewed by Saam Barati.
+
+ 8 bytes from reordering fields
+ 8 more bytes by making the enum State only use 1 byte.
+
+ * bytecode/GetByIdStatus.cpp:
+ (JSC::GetByIdStatus::GetByIdStatus):
+ * bytecode/GetByIdStatus.h:
+
+2019-03-08 Robin Morisset <[email protected]>
+
PutByIdVariant can be shrunk by 8 bytes
https://bugs.webkit.org/show_bug.cgi?id=195482
Modified: trunk/Source/_javascript_Core/bytecode/GetByIdStatus.cpp (242658 => 242659)
--- trunk/Source/_javascript_Core/bytecode/GetByIdStatus.cpp 2019-03-08 23:20:15 UTC (rev 242658)
+++ trunk/Source/_javascript_Core/bytecode/GetByIdStatus.cpp 2019-03-08 23:24:25 UTC (rev 242659)
@@ -142,11 +142,11 @@
#if ENABLE(JIT)
GetByIdStatus::GetByIdStatus(const ModuleNamespaceAccessCase& accessCase)
- : m_state(ModuleNamespace)
- , m_wasSeenInJIT(true)
- , m_moduleNamespaceObject(accessCase.moduleNamespaceObject())
+ : m_moduleNamespaceObject(accessCase.moduleNamespaceObject())
, m_moduleEnvironment(accessCase.moduleEnvironment())
, m_scopeOffset(accessCase.scopeOffset())
+ , m_state(ModuleNamespace)
+ , m_wasSeenInJIT(true)
{
}
Modified: trunk/Source/_javascript_Core/bytecode/GetByIdStatus.h (242658 => 242659)
--- trunk/Source/_javascript_Core/bytecode/GetByIdStatus.h 2019-03-08 23:20:15 UTC (rev 242658)
+++ trunk/Source/_javascript_Core/bytecode/GetByIdStatus.h 2019-03-08 23:24:25 UTC (rev 242659)
@@ -45,7 +45,7 @@
class GetByIdStatus {
public:
- enum State {
+ enum State : uint8_t {
// It's uncached so we have no information.
NoInformation,
// It's cached for a simple access to a known object property with
@@ -156,12 +156,13 @@
bool appendVariant(const GetByIdVariant&);
- State m_state;
+
Vector<GetByIdVariant, 1> m_variants;
- bool m_wasSeenInJIT { false };
JSModuleNamespaceObject* m_moduleNamespaceObject { nullptr };
JSModuleEnvironment* m_moduleEnvironment { nullptr };
ScopeOffset m_scopeOffset { };
+ State m_state;
+ bool m_wasSeenInJIT { false };
};
} // namespace JSC
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
