Title: [242666] trunk/Source/WebKit
- Revision
- 242666
- Author
- [email protected]
- Date
- 2019-03-08 16:59:40 -0800 (Fri, 08 Mar 2019)
Log Message
Enable ProcessAssertions on iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=195479
Reviewed by Alexey Proskuryakov.
Enable ProcessAssertions on iOS Simulator. We have some layout tests timing out in the
iOS Simulator due to the WebContent process suspending. Turning on ProcessAssertions in
the iOS Simulator seems to make those tests pass.
* UIProcess/ProcessAssertion.cpp:
* UIProcess/ProcessAssertion.h:
* UIProcess/ios/ProcessAssertionIOS.mm:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (242665 => 242666)
--- trunk/Source/WebKit/ChangeLog 2019-03-09 00:53:46 UTC (rev 242665)
+++ trunk/Source/WebKit/ChangeLog 2019-03-09 00:59:40 UTC (rev 242666)
@@ -1,5 +1,20 @@
2019-03-08 Chris Dumez <[email protected]>
+ Enable ProcessAssertions on iOS Simulator
+ https://bugs.webkit.org/show_bug.cgi?id=195479
+
+ Reviewed by Alexey Proskuryakov.
+
+ Enable ProcessAssertions on iOS Simulator. We have some layout tests timing out in the
+ iOS Simulator due to the WebContent process suspending. Turning on ProcessAssertions in
+ the iOS Simulator seems to make those tests pass.
+
+ * UIProcess/ProcessAssertion.cpp:
+ * UIProcess/ProcessAssertion.h:
+ * UIProcess/ios/ProcessAssertionIOS.mm:
+
+2019-03-08 Chris Dumez <[email protected]>
+
Add support for Device Orientation / Motion permission API
https://bugs.webkit.org/show_bug.cgi?id=195329
<rdar://problem/47645367>
Modified: trunk/Source/WebKit/UIProcess/ProcessAssertion.cpp (242665 => 242666)
--- trunk/Source/WebKit/UIProcess/ProcessAssertion.cpp 2019-03-09 00:53:46 UTC (rev 242665)
+++ trunk/Source/WebKit/UIProcess/ProcessAssertion.cpp 2019-03-09 00:59:40 UTC (rev 242666)
@@ -26,7 +26,7 @@
#include "config.h"
#include "ProcessAssertion.h"
-#if !PLATFORM(IOS_FAMILY) || PLATFORM(IOS_FAMILY_SIMULATOR)
+#if !PLATFORM(IOS_FAMILY)
namespace WebKit {
@@ -44,4 +44,4 @@
} // namespace WebKit
-#endif // !PLATFORM(IOS_FAMILY) || PLATFORM(IOS_FAMILY_SIMULATOR)
+#endif // !PLATFORM(IOS_FAMILY)
Modified: trunk/Source/WebKit/UIProcess/ProcessAssertion.h (242665 => 242666)
--- trunk/Source/WebKit/UIProcess/ProcessAssertion.h 2019-03-09 00:53:46 UTC (rev 242665)
+++ trunk/Source/WebKit/UIProcess/ProcessAssertion.h 2019-03-09 00:59:40 UTC (rev 242666)
@@ -34,7 +34,7 @@
#include <unistd.h>
#endif
-#if PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR)
+#if PLATFORM(IOS_FAMILY)
#include <wtf/RetainPtr.h>
OBJC_CLASS BKSProcessAssertion;
#endif
@@ -66,7 +66,7 @@
AssertionState state() const { return m_assertionState; }
virtual void setState(AssertionState);
-#if PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR)
+#if PLATFORM(IOS_FAMILY)
protected:
enum class Validity { No, Yes, Unset };
Validity validity() const { return m_validity; }
@@ -75,7 +75,7 @@
#endif
private:
-#if PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR)
+#if PLATFORM(IOS_FAMILY)
RetainPtr<BKSProcessAssertion> m_assertion;
Validity m_validity { Validity::Unset };
#endif
@@ -83,7 +83,7 @@
Client* m_client { nullptr };
};
-#if PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR)
+#if PLATFORM(IOS_FAMILY)
class ProcessAndUIAssertion final : public ProcessAssertion {
public:
@@ -104,6 +104,6 @@
using ProcessAndUIAssertion = ProcessAssertion;
-#endif // PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR)
+#endif // PLATFORM(IOS_FAMILY)
} // namespace WebKit
Modified: trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm (242665 => 242666)
--- trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm 2019-03-09 00:53:46 UTC (rev 242665)
+++ trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm 2019-03-09 00:59:40 UTC (rev 242666)
@@ -26,7 +26,7 @@
#import "config.h"
#import "ProcessAssertion.h"
-#if PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR)
+#if PLATFORM(IOS_FAMILY)
#import "AssertionServicesSPI.h"
#import "Logging.h"
@@ -256,4 +256,4 @@
} // namespace WebKit
-#endif // PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR)
+#endif // PLATFORM(IOS_FAMILY)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
