Title: [242731] trunk/Source/WebInspectorUI
- Revision
- 242731
- Author
- [email protected]
- Date
- 2019-03-11 13:05:07 -0700 (Mon, 11 Mar 2019)
Log Message
REGRESSION(r242622): Web Inspector: Fix asserts "Overridden property is missing overridingProperty"
https://bugs.webkit.org/show_bug.cgi?id=195515
<rdar://problem/48737315>
Reviewed by Matt Baker.
* UserInterface/Views/SpreadsheetStyleProperty.js:
(WI.SpreadsheetStyleProperty.prototype.updateStatus):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (242730 => 242731)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-03-11 20:03:24 UTC (rev 242730)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-03-11 20:05:07 UTC (rev 242731)
@@ -1,3 +1,14 @@
+2019-03-11 Nikita Vasilyev <[email protected]>
+
+ REGRESSION(r242622): Web Inspector: Fix asserts "Overridden property is missing overridingProperty"
+ https://bugs.webkit.org/show_bug.cgi?id=195515
+ <rdar://problem/48737315>
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Views/SpreadsheetStyleProperty.js:
+ (WI.SpreadsheetStyleProperty.prototype.updateStatus):
+
2019-03-07 Nikita Vasilyev <[email protected]>
Web Inspector: Styles: overridden CSS property should have go-to button to jump to effective property
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js (242730 => 242731)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js 2019-03-11 20:03:24 UTC (rev 242730)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js 2019-03-11 20:05:07 UTC (rev 242731)
@@ -262,7 +262,7 @@
let elementTitle = "";
if (this._property.overridden) {
- if (!this._jumpToEffectivePropertyButton && this._delegate && this._delegate.spreadsheetStylePropertySelectByProperty) {
+ if (!this._jumpToEffectivePropertyButton && this._delegate && this._delegate.spreadsheetStylePropertySelectByProperty && WI.settings.experimentalEnableStylesJumpToEffective.value) {
console.assert(this._property.overridingProperty, `Overridden property is missing overridingProperty: ${this._property.formattedText}`);
if (this._property.overridingProperty) {
this._jumpToEffectivePropertyButton = WI.createGoToArrowButton();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
