Diff
Modified: trunk/LayoutTests/ChangeLog (242762 => 242763)
--- trunk/LayoutTests/ChangeLog 2019-03-12 01:53:58 UTC (rev 242762)
+++ trunk/LayoutTests/ChangeLog 2019-03-12 01:58:17 UTC (rev 242763)
@@ -1,3 +1,14 @@
+2019-03-11 Zalan Bujtas <[email protected]>
+
+ [Synthetic Click] Dispatch mouseout soon after mouseup
+ https://bugs.webkit.org/show_bug.cgi?id=195575
+ <rdar://problem/47093049>
+
+ Reviewed by Simon Fraser.
+
+ * fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click-expected.txt: Added.
+ * fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click.html: Added.
+
2019-03-11 Justin Fan <[email protected]>
[Web GPU] Update GPUSwapChainDescriptor, GPUSwapChain and implement GPUCanvasContext
Modified: trunk/LayoutTests/fast/events/touch/ios/content-observation/visibility-change-happens-while-in-mousemoved.html (242762 => 242763)
--- trunk/LayoutTests/fast/events/touch/ios/content-observation/visibility-change-happens-while-in-mousemoved.html 2019-03-12 01:53:58 UTC (rev 242762)
+++ trunk/LayoutTests/fast/events/touch/ios/content-observation/visibility-change-happens-while-in-mousemoved.html 2019-03-12 01:58:17 UTC (rev 242763)
@@ -45,7 +45,11 @@
testRunner.notifyDone();
}, false);
-becomesVisible.addEventListener("click", function( event ) {
+tapthis.addEventListener("mouseout", function( event ) {
+ result.innerHTML = result.innerHTML + " mouseout should NOT be triggered ";
+}, false);
+
+becomesVisible.addEventListener("click", function( event ) {
result.innerHTML = "clicked hidden";
}, false);
Modified: trunk/Source/WebCore/ChangeLog (242762 => 242763)
--- trunk/Source/WebCore/ChangeLog 2019-03-12 01:53:58 UTC (rev 242762)
+++ trunk/Source/WebCore/ChangeLog 2019-03-12 01:58:17 UTC (rev 242763)
@@ -1,3 +1,19 @@
+2019-03-11 Zalan Bujtas <[email protected]>
+
+ [Synthetic Click] Dispatch mouseout soon after mouseup
+ https://bugs.webkit.org/show_bug.cgi?id=195575
+ <rdar://problem/47093049>
+
+ Reviewed by Simon Fraser.
+
+ Let's fire a mouseout event when a click is submitted as the result of a tap. It helps to dismiss content which would otherwise require you to move the mouse (cases like control bar on youtube.com).
+
+ Test: fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click.html
+
+ * page/EventHandler.h:
+ * page/ios/EventHandlerIOS.mm:
+ (WebCore::EventHandler::dispatchFakeMouseOut):
+
2019-03-11 Youenn Fablet <[email protected]>
REGRESSION: (r242181) API test DragAndDropTests.ExternalSourcePlainTextToIFrame is Timing out
Modified: trunk/Source/WebCore/page/EventHandler.cpp (242762 => 242763)
--- trunk/Source/WebCore/page/EventHandler.cpp 2019-03-12 01:53:58 UTC (rev 242762)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2019-03-12 01:58:17 UTC (rev 242763)
@@ -1978,7 +1978,7 @@
#endif
if (onlyUpdateScrollbars) {
if (shouldSendMouseEventsToInactiveWindows())
- updateMouseEventTargetNode(mouseEvent.targetNode(), platformMouseEvent, true);
+ updateMouseEventTargetNode(mouseEvent.targetNode(), platformMouseEvent, FireMouseOverOut::Yes);
return true;
}
@@ -1993,7 +1993,7 @@
if (newSubframe) {
// Update over/out state before passing the event to the subframe.
- updateMouseEventTargetNode(mouseEvent.targetNode(), platformMouseEvent, true);
+ updateMouseEventTargetNode(mouseEvent.targetNode(), platformMouseEvent, FireMouseOverOut::Yes);
// Event dispatch in updateMouseEventTargetNode may have caused the subframe of the target
// node to be detached from its FrameView, in which case the event should not be passed.
@@ -2476,7 +2476,7 @@
return false;
}
-void EventHandler::updateMouseEventTargetNode(Node* targetNode, const PlatformMouseEvent& platformMouseEvent, bool fireMouseOverOut)
+void EventHandler::updateMouseEventTargetNode(Node* targetNode, const PlatformMouseEvent& platformMouseEvent, FireMouseOverOut fireMouseOverOut)
{
Ref<Frame> protectedFrame(m_frame);
Element* targetElement = nullptr;
@@ -2494,7 +2494,7 @@
m_elementUnderMouse = targetElement;
// Fire mouseout/mouseover if the mouse has shifted to a different node.
- if (fireMouseOverOut) {
+ if (fireMouseOverOut == FireMouseOverOut::Yes) {
auto scrollableAreaForLastNode = enclosingScrollableArea(m_lastElementUnderMouse.get());
auto scrollableAreaForNodeUnderMouse = enclosingScrollableArea(m_elementUnderMouse.get());
Page* page = m_frame.page();
@@ -2588,7 +2588,7 @@
if (auto* view = m_frame.view())
view->disableLayerFlushThrottlingTemporarilyForInteraction();
- updateMouseEventTargetNode(targetNode, platformMouseEvent, setUnder);
+ updateMouseEventTargetNode(targetNode, platformMouseEvent, setUnder ? FireMouseOverOut::Yes : FireMouseOverOut::No);
if (m_elementUnderMouse && !m_elementUnderMouse->dispatchMouseEvent(platformMouseEvent, eventType, clickCount))
return false;
Modified: trunk/Source/WebCore/page/EventHandler.h (242762 => 242763)
--- trunk/Source/WebCore/page/EventHandler.h 2019-03-12 01:53:58 UTC (rev 242762)
+++ trunk/Source/WebCore/page/EventHandler.h 2019-03-12 01:58:17 UTC (rev 242763)
@@ -241,6 +241,7 @@
#if PLATFORM(IOS_FAMILY)
void defaultTouchEventHandler(Node&, TouchEvent&);
+ WEBCORE_EXPORT void dispatchSyntheticMouseOut(const PlatformMouseEvent&);
#endif
#if ENABLE(CONTEXT_MENUS)
@@ -404,9 +405,9 @@
Node* nodeUnderMouse() const;
- void updateMouseEventTargetNode(Node*, const PlatformMouseEvent&, bool fireMouseOverOut);
- void fireMouseOverOut(bool fireMouseOver = true, bool fireMouseOut = true, bool updateLastNodeUnderMouse = true);
-
+ enum class FireMouseOverOut { No, Yes };
+ void updateMouseEventTargetNode(Node*, const PlatformMouseEvent&, FireMouseOverOut);
+
MouseEventWithHitTestResults prepareMouseEvent(const HitTestRequest&, const PlatformMouseEvent&);
bool dispatchMouseEvent(const AtomicString& eventType, Node* target, bool cancelable, int clickCount, const PlatformMouseEvent&, bool setUnder);
Modified: trunk/Source/WebCore/page/ios/EventHandlerIOS.mm (242762 => 242763)
--- trunk/Source/WebCore/page/ios/EventHandlerIOS.mm 2019-03-12 01:53:58 UTC (rev 242762)
+++ trunk/Source/WebCore/page/ios/EventHandlerIOS.mm 2019-03-12 01:58:17 UTC (rev 242763)
@@ -515,6 +515,11 @@
return false;
}
+void EventHandler::dispatchSyntheticMouseOut(const PlatformMouseEvent& platformMouseEvent)
+{
+ updateMouseEventTargetNode(nullptr, platformMouseEvent, FireMouseOverOut::Yes);
+}
+
bool EventHandler::passMousePressEventToSubframe(MouseEventWithHitTestResults& mev, Frame* subframe)
{
// WebKit1 code path.
Modified: trunk/Source/WebKit/ChangeLog (242762 => 242763)
--- trunk/Source/WebKit/ChangeLog 2019-03-12 01:53:58 UTC (rev 242762)
+++ trunk/Source/WebKit/ChangeLog 2019-03-12 01:58:17 UTC (rev 242763)
@@ -1,3 +1,14 @@
+2019-03-11 Zalan Bujtas <[email protected]>
+
+ [Synthetic Click] Dispatch mouseout soon after mouseup
+ https://bugs.webkit.org/show_bug.cgi?id=195575
+ <rdar://problem/47093049>
+
+ Reviewed by Simon Fraser.
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::completeSyntheticClick):
+
2019-03-11 Tim Horton <[email protected]>
API test WebKit.RequestTextInputContext fails on iOS
Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (242762 => 242763)
--- trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2019-03-12 01:53:58 UTC (rev 242762)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2019-03-12 01:58:17 UTC (rev 242763)
@@ -640,6 +640,10 @@
if (newFocusedElement && newFocusedElement == oldFocusedElement)
elementDidRefocus(*newFocusedElement);
+ nodeRespondingToClick.document().frame()->eventHandler().dispatchSyntheticMouseOut(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::NoType, 0, shiftKey, ctrlKey, altKey, metaKey, WallTime::now(), 0, WebCore::NoTap));
+ if (m_isClosed)
+ return;
+
if (!tapWasHandled || !nodeRespondingToClick.isElementNode())
send(Messages::WebPageProxy::DidNotHandleTapAsClick(roundedIntPoint(location)));
