Title: [242772] trunk/Source/WebInspectorUI
- Revision
- 242772
- Author
- [email protected]
- Date
- 2019-03-11 21:56:41 -0700 (Mon, 11 Mar 2019)
Log Message
Web Inspector: REGRESSION: Network Cookies Table does not load
https://bugs.webkit.org/show_bug.cgi?id=195599
Patch by Joseph Pecoraro <[email protected]> on 2019-03-11
Reviewed by Devin Rousso.
* UserInterface/Views/ResourceCookiesContentView.js:
(WI.ResourceCookiesContentView.prototype.tableIndexForRepresentedObject):
(WI.ResourceCookiesContentView.prototype.tableRepresentedObjectForIndex):
Include needed delegate methods.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (242771 => 242772)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-03-12 04:12:32 UTC (rev 242771)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-03-12 04:56:41 UTC (rev 242772)
@@ -1,3 +1,15 @@
+2019-03-11 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: REGRESSION: Network Cookies Table does not load
+ https://bugs.webkit.org/show_bug.cgi?id=195599
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/ResourceCookiesContentView.js:
+ (WI.ResourceCookiesContentView.prototype.tableIndexForRepresentedObject):
+ (WI.ResourceCookiesContentView.prototype.tableRepresentedObjectForIndex):
+ Include needed delegate methods.
+
2019-03-11 Devin Rousso <[email protected]>
Web Inspector: use -webkit-{margin,padding}-{start,end} instead of [dir={ltr/rtl}] rules
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceCookiesContentView.js (242771 => 242772)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceCookiesContentView.js 2019-03-12 04:12:32 UTC (rev 242771)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceCookiesContentView.js 2019-03-12 04:56:41 UTC (rev 242772)
@@ -56,6 +56,21 @@
table.reloadData();
}
+ tableIndexForRepresentedObject(table, object)
+ {
+ let cookies = this._dataSourceForTable(table);
+ let index = cookies.indexOf(object);
+ console.assert(index >= 0);
+ return index;
+ }
+
+ tableRepresentedObjectForIndex(table, index)
+ {
+ let cookies = this._dataSourceForTable(table);
+ console.assert(index >= 0 && index < cookies.length);
+ return cookies[index];
+ }
+
// Table delegate
tableShouldSelectRow(table, cell, column, rowIndex)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes