Title: [242785] trunk/Source/WebInspectorUI
- Revision
- 242785
- Author
- [email protected]
- Date
- 2019-03-12 00:10:58 -0700 (Tue, 12 Mar 2019)
Log Message
Web Inspector: Timelines - Improve handling of past recordings (readonly)
https://bugs.webkit.org/show_bug.cgi?id=195594
Patch by Joseph Pecoraro <[email protected]> on 2019-03-12
Reviewed by Devin Rousso.
* UserInterface/Views/TimelineRecordingContentView.js:
(WI.TimelineRecordingContentView.prototype._clearTimeline):
Don't allow clearing of a readonly recording.
* UserInterface/Views/TimelineTabContentView.js:
(WI.TimelineTabContentView.prototype._toggleRecordingOnSpacebar):
Don't do anything when viewing a readonly recording.
(WI.TimelineTabContentView.prototype._recordButtonClicked):
Start a new recording if viewing a readonly recording.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (242784 => 242785)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-03-12 06:58:20 UTC (rev 242784)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-03-12 07:10:58 UTC (rev 242785)
@@ -1,3 +1,21 @@
+2019-03-12 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Timelines - Improve handling of past recordings (readonly)
+ https://bugs.webkit.org/show_bug.cgi?id=195594
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/TimelineRecordingContentView.js:
+ (WI.TimelineRecordingContentView.prototype._clearTimeline):
+ Don't allow clearing of a readonly recording.
+
+ * UserInterface/Views/TimelineTabContentView.js:
+ (WI.TimelineTabContentView.prototype._toggleRecordingOnSpacebar):
+ Don't do anything when viewing a readonly recording.
+
+ (WI.TimelineTabContentView.prototype._recordButtonClicked):
+ Start a new recording if viewing a readonly recording.
+
2019-03-11 Joseph Pecoraro <[email protected]>
Web Inspector: REGRESSION: Network Cookies Table does not load
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js (242784 => 242785)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2019-03-12 06:58:20 UTC (rev 242784)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2019-03-12 07:10:58 UTC (rev 242785)
@@ -564,6 +564,9 @@
_clearTimeline(event)
{
+ if (this._recording.readonly)
+ return;
+
if (WI.timelineManager.activeRecording === this._recording && WI.timelineManager.isCapturing())
WI.timelineManager.stopCapturing();
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js (242784 => 242785)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js 2019-03-12 06:58:20 UTC (rev 242784)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineTabContentView.js 2019-03-12 07:10:58 UTC (rev 242785)
@@ -445,6 +445,9 @@
_toggleRecordingOnSpacebar(event)
{
+ if (WI.timelineManager.activeRecording.readonly)
+ return;
+
if (WI.isEventTargetAnEditableField(event))
return;
@@ -480,6 +483,9 @@
_recordButtonClicked(event)
{
let shouldCreateNewRecording = window.event ? window.event.shiftKey : false;
+ if (WI.timelineManager.activeRecording.readonly)
+ shouldCreateNewRecording = true;
+
this._recordButton.toggled = !WI.timelineManager.isCapturing();
this._toggleRecording(shouldCreateNewRecording);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
