Title: [242802] trunk/Source/_javascript_Core
- Revision
- 242802
- Author
- rmoris...@apple.com
- Date
- 2019-03-12 10:42:42 -0700 (Tue, 12 Mar 2019)
Log Message
blocksInPreOrder and blocksInPostOrder should reserve the right capacity for their result vector
https://bugs.webkit.org/show_bug.cgi?id=195595
Reviewed by Saam Barati.
Also change BlockList from being Vector<BasicBlock*, 5> to Vector<BasicBlock*>
* dfg/DFGBasicBlock.h:
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::blocksInPreOrder):
(JSC::DFG::Graph::blocksInPostOrder):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (242801 => 242802)
--- trunk/Source/_javascript_Core/ChangeLog 2019-03-12 17:41:59 UTC (rev 242801)
+++ trunk/Source/_javascript_Core/ChangeLog 2019-03-12 17:42:42 UTC (rev 242802)
@@ -1,3 +1,17 @@
+2019-03-12 Robin Morisset <rmoris...@apple.com>
+
+ blocksInPreOrder and blocksInPostOrder should reserve the right capacity for their result vector
+ https://bugs.webkit.org/show_bug.cgi?id=195595
+
+ Reviewed by Saam Barati.
+
+ Also change BlockList from being Vector<BasicBlock*, 5> to Vector<BasicBlock*>
+
+ * dfg/DFGBasicBlock.h:
+ * dfg/DFGGraph.cpp:
+ (JSC::DFG::Graph::blocksInPreOrder):
+ (JSC::DFG::Graph::blocksInPostOrder):
+
2019-03-11 Ross Kirsling <ross.kirsl...@sony.com>
Add Optional to Forward.h.
Modified: trunk/Source/_javascript_Core/dfg/DFGBasicBlock.h (242801 => 242802)
--- trunk/Source/_javascript_Core/dfg/DFGBasicBlock.h 2019-03-12 17:41:59 UTC (rev 242801)
+++ trunk/Source/_javascript_Core/dfg/DFGBasicBlock.h 2019-03-12 17:42:42 UTC (rev 242802)
@@ -257,7 +257,7 @@
BlockNodeList m_nodes;
};
-typedef Vector<BasicBlock*, 5> BlockList;
+typedef Vector<BasicBlock*> BlockList;
static inline unsigned getBytecodeBeginForBlock(BasicBlock** basicBlock)
{
Modified: trunk/Source/_javascript_Core/dfg/DFGGraph.cpp (242801 => 242802)
--- trunk/Source/_javascript_Core/dfg/DFGGraph.cpp 2019-03-12 17:41:59 UTC (rev 242801)
+++ trunk/Source/_javascript_Core/dfg/DFGGraph.cpp 2019-03-12 17:42:42 UTC (rev 242802)
@@ -888,6 +888,7 @@
BlockList Graph::blocksInPreOrder()
{
BlockList result;
+ result.reserveInitialCapacity(m_blocks.size());
BlockWorklist worklist;
for (BasicBlock* entrypoint : m_roots)
worklist.push(entrypoint);
@@ -926,6 +927,7 @@
BlockList Graph::blocksInPostOrder(bool isSafeToValidate)
{
BlockList result;
+ result.reserveInitialCapacity(m_blocks.size());
PostOrderBlockWorklist worklist;
for (BasicBlock* entrypoint : m_roots)
worklist.push(entrypoint);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
