Title: [242815] trunk
Revision
242815
Author
[email protected]
Date
2019-03-12 12:28:40 -0700 (Tue, 12 Mar 2019)

Log Message

Layout Test imported/w3c/web-platform-tests/IndexedDB/transaction-abort-request-error.html is failing
https://bugs.webkit.org/show_bug.cgi?id=195570

Reviewed by Brady Eidson.

LayoutTests/imported/w3c:

Updated test expectation to PASS.

* web-platform-tests/IndexedDB/transaction-abort-request-error-expected.txt:

Source/WebCore:

IDBRequest result should be undefined if it is never set.

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):

Modified Paths

Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (242814 => 242815)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2019-03-12 19:18:51 UTC (rev 242814)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2019-03-12 19:28:40 UTC (rev 242815)
@@ -1,3 +1,14 @@
+2019-03-12  Sihui Liu  <[email protected]>
+
+        Layout Test imported/w3c/web-platform-tests/IndexedDB/transaction-abort-request-error.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=195570
+
+        Reviewed by Brady Eidson.
+
+        Updated test expectation to PASS.
+
+        * web-platform-tests/IndexedDB/transaction-abort-request-error-expected.txt:
+
 2019-03-12  Rob Buis  <[email protected]>
 
         Implement further CORS restrictions

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/transaction-abort-request-error-expected.txt (242814 => 242815)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/transaction-abort-request-error-expected.txt	2019-03-12 19:18:51 UTC (rev 242814)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/transaction-abort-request-error-expected.txt	2019-03-12 19:28:40 UTC (rev 242815)
@@ -1,3 +1,3 @@
 
-FAIL Properties of error events fired at requests when aborting a transaction assert_equals: Request's result should be undefined expected (undefined) undefined but got (object) null
+PASS Properties of error events fired at requests when aborting a transaction 
 

Modified: trunk/Source/WebCore/ChangeLog (242814 => 242815)


--- trunk/Source/WebCore/ChangeLog	2019-03-12 19:18:51 UTC (rev 242814)
+++ trunk/Source/WebCore/ChangeLog	2019-03-12 19:28:40 UTC (rev 242815)
@@ -1,3 +1,15 @@
+2019-03-12  Sihui Liu  <[email protected]>
+
+        Layout Test imported/w3c/web-platform-tests/IndexedDB/transaction-abort-request-error.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=195570
+
+        Reviewed by Brady Eidson.
+
+        IDBRequest result should be undefined if it is never set.
+
+        * Modules/indexeddb/IDBRequest.cpp:
+        (WebCore::IDBRequest::IDBRequest):
+
 2019-03-12  Youenn Fablet  <[email protected]>
 
         Rename originsMatch in originSerializationsMatch

Modified: trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp (242814 => 242815)


--- trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp	2019-03-12 19:18:51 UTC (rev 242814)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp	2019-03-12 19:28:40 UTC (rev 242815)
@@ -85,7 +85,7 @@
     , m_resourceIdentifier(connectionProxy)
     , m_connectionProxy(connectionProxy)
 {
-    m_result = NullResultType::Empty;
+    m_result = NullResultType::Undefined;
     suspendIfNeeded();
 }
 
@@ -96,7 +96,7 @@
     , m_source(&objectStore)
     , m_connectionProxy(transaction.database().connectionProxy())
 {
-    m_result = NullResultType::Empty;
+    m_result = NullResultType::Undefined;
     suspendIfNeeded();
 }
 
@@ -113,7 +113,7 @@
         [this] (const auto& value) { this->m_source = IDBRequest::Source { value }; }
     );
 
-    m_result = NullResultType::Empty;
+    m_result = NullResultType::Undefined;
     cursor.setRequest(*this);
 }
 
@@ -124,7 +124,7 @@
     , m_source(&index)
     , m_connectionProxy(transaction.database().connectionProxy())
 {
-    m_result = NullResultType::Empty;
+    m_result = NullResultType::Undefined;
     suspendIfNeeded();
 }
 
@@ -136,7 +136,7 @@
     , m_requestedObjectStoreRecordType(type)
     , m_connectionProxy(transaction.database().connectionProxy())
 {
-    m_result = NullResultType::Empty;
+    m_result = NullResultType::Undefined;
     suspendIfNeeded();
 }
 
@@ -143,7 +143,7 @@
 IDBRequest::IDBRequest(ScriptExecutionContext& context, IDBIndex& index, IndexedDB::IndexRecordType requestedRecordType, IDBTransaction& transaction)
     : IDBRequest(context, index, transaction)
 {
-    m_result = NullResultType::Empty;
+    m_result = NullResultType::Undefined;
     m_requestedIndexRecordType = requestedRecordType;
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to