Title: [242821] trunk/Source/WebInspectorUI
- Revision
- 242821
- Author
- [email protected]
- Date
- 2019-03-12 13:10:32 -0700 (Tue, 12 Mar 2019)
Log Message
Web Inspector: Keyboard shortcut for settings tab too greedy on non-US keyboards
https://bugs.webkit.org/show_bug.cgi?id=192947
<rdar://problem/46886779>
Reviewed by Devin Rousso.
* UserInterface/Base/Main.js:
(WI._showSettingsTab):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (242820 => 242821)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-03-12 20:05:52 UTC (rev 242820)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-03-12 20:10:32 UTC (rev 242821)
@@ -1,3 +1,14 @@
+2019-03-12 Nikita Vasilyev <[email protected]>
+
+ Web Inspector: Keyboard shortcut for settings tab too greedy on non-US keyboards
+ https://bugs.webkit.org/show_bug.cgi?id=192947
+ <rdar://problem/46886779>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Base/Main.js:
+ (WI._showSettingsTab):
+
2019-03-12 Devin Rousso <[email protected]>
Web Inspector: Elements: provide node context menu items for event listeners sorted by node
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (242820 => 242821)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2019-03-12 20:05:52 UTC (rev 242820)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2019-03-12 20:10:32 UTC (rev 242821)
@@ -713,7 +713,8 @@
WI._showSettingsTab = function(event)
{
- this.tabBrowser.showTabForContentView(this.settingsTabContentView);
+ if (event.keyIdentifier === "U+002C") // ","
+ this.tabBrowser.showTabForContentView(this.settingsTabContentView);
};
WI._tryToRestorePendingTabs = function()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
