Title: [242828] trunk/Source/WTF
- Revision
- 242828
- Author
- [email protected]
- Date
- 2019-03-12 14:03:08 -0700 (Tue, 12 Mar 2019)
Log Message
Unreviewed, rolling out r242747.
https://bugs.webkit.org/show_bug.cgi?id=195641
Performance measurement is difficult in this period, rolling
out it and rolling in later to isolate it from the other
sensitive patches (Requested by yusukesuzuki on #webkit).
Reverted changeset:
"[JSC] Make StaticStringImpl & StaticSymbolImpl actually
static"
https://bugs.webkit.org/show_bug.cgi?id=194212
https://trac.webkit.org/changeset/242747
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (242827 => 242828)
--- trunk/Source/WTF/ChangeLog 2019-03-12 20:58:12 UTC (rev 242827)
+++ trunk/Source/WTF/ChangeLog 2019-03-12 21:03:08 UTC (rev 242828)
@@ -1,3 +1,19 @@
+2019-03-12 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r242747.
+ https://bugs.webkit.org/show_bug.cgi?id=195641
+
+ Performance measurement is difficult in this period, rolling
+ out it and rolling in later to isolate it from the other
+ sensitive patches (Requested by yusukesuzuki on #webkit).
+
+ Reverted changeset:
+
+ "[JSC] Make StaticStringImpl & StaticSymbolImpl actually
+ static"
+ https://bugs.webkit.org/show_bug.cgi?id=194212
+ https://trac.webkit.org/changeset/242747
+
2019-03-12 Robin Morisset <[email protected]>
A lot more classes have padding that can be reduced by reordering their fields
Modified: trunk/Source/WTF/wtf/text/StringImpl.h (242827 => 242828)
--- trunk/Source/WTF/wtf/text/StringImpl.h 2019-03-12 20:58:12 UTC (rev 242827)
+++ trunk/Source/WTF/wtf/text/StringImpl.h 2019-03-12 21:03:08 UTC (rev 242828)
@@ -1064,8 +1064,6 @@
{
STRING_STATS_REF_STRING(*this);
- if (UNLIKELY(isStatic()))
- return;
m_refCount += s_refCountIncrement;
}
@@ -1073,8 +1071,6 @@
{
STRING_STATS_DEREF_STRING(*this);
- if (UNLIKELY(isStatic()))
- return;
unsigned tempRefCount = m_refCount - s_refCountIncrement;
if (!tempRefCount) {
StringImpl::destroy(this);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
