Title: [242835] trunk/Source/WebKitLegacy/mac
- Revision
- 242835
- Author
- [email protected]
- Date
- 2019-03-12 17:15:52 -0700 (Tue, 12 Mar 2019)
Log Message
Remove a site specific hack for AppleConnect plugin
https://bugs.webkit.org/show_bug.cgi?id=195643
Reviewed by Simon Fraser.
r66437 added a workaround for AppleConnect plugin.
Remove this code since Safari doesn't even use WebKitLegacy anymore,
and other WebKit clients support AppleConnect plugins.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin):
Modified Paths
Diff
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (242834 => 242835)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2019-03-13 00:12:15 UTC (rev 242834)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2019-03-13 00:15:52 UTC (rev 242835)
@@ -1,3 +1,18 @@
+2019-03-12 Ryosuke Niwa <[email protected]>
+
+ Remove a site specific hack for AppleConnect plugin
+ https://bugs.webkit.org/show_bug.cgi?id=195643
+
+ Reviewed by Simon Fraser.
+
+ r66437 added a workaround for AppleConnect plugin.
+
+ Remove this code since Safari doesn't even use WebKitLegacy anymore,
+ and other WebKit clients support AppleConnect plugins.
+
+ * WebCoreSupport/WebFrameLoaderClient.mm:
+ (WebFrameLoaderClient::createPlugin):
+
2019-03-11 Ryan Haddad <[email protected]>
Unreviewed, rolling out r242688, r242643, r242624.
Modified: trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm (242834 => 242835)
--- trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm 2019-03-13 00:12:15 UTC (rev 242834)
+++ trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm 2019-03-13 00:15:52 UTC (rev 242835)
@@ -1920,29 +1920,13 @@
int errorCode = 0;
WebView *webView = getWebView(m_webFrame.get());
-#if !PLATFORM(IOS_FAMILY)
- SEL selector = @selector(webView:plugInViewWithArguments:);
-#endif
-
Document* document = core(m_webFrame.get())->document();
NSURL *baseURL = document->baseURL();
NSURL *pluginURL = url;
-
- // <rdar://problem/8366089>: AppleConnect has a bug where it does not
- // understand the parameter names specified in the <object> element that
- // embeds its plug-in. This site-specific hack works around the issue by
- // converting the parameter names to lowercase before passing them to the
- // plug-in.
-#if !PLATFORM(IOS_FAMILY)
- Frame* frame = core(m_webFrame.get());
-#endif
NSMutableArray *attributeKeys = kit(paramNames);
+
#if !PLATFORM(IOS_FAMILY)
- if (frame && frame->settings().needsSiteSpecificQuirks() && equalLettersIgnoringASCIICase(mimeType, "application/x-snkp")) {
- for (NSUInteger i = 0; i < [attributeKeys count]; ++i)
- [attributeKeys replaceObjectAtIndex:i withObject:[[attributeKeys objectAtIndex:i] lowercaseString]];
- }
-
+ SEL selector = @selector(webView:plugInViewWithArguments:);
if ([[webView UIDelegate] respondsToSelector:selector]) {
NSMutableDictionary *attributes = [[NSMutableDictionary alloc] initWithObjects:kit(paramValues) forKeys:attributeKeys];
NSDictionary *arguments = [[NSDictionary alloc] initWithObjectsAndKeys:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
