Title: [242853] branches/safari-607-branch/Source/WebCore
Revision
242853
Author
[email protected]
Date
2019-03-13 01:24:26 -0700 (Wed, 13 Mar 2019)

Log Message

Cherry-pick r241632. rdar://problem/48839379

    Sample domainsVisited diagnostic logging
    https://bugs.webkit.org/show_bug.cgi?id=194657

    Reviewed by Ryosuke Niwa.

    Sample domainsVisited diagnostic logging, we are getting a lot of data from
    this key and this is hurting our other keys.

    * page/Page.cpp:
    (WebCore::Page::logNavigation):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@241632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-607-branch/Source/WebCore/ChangeLog (242852 => 242853)


--- branches/safari-607-branch/Source/WebCore/ChangeLog	2019-03-13 08:24:23 UTC (rev 242852)
+++ branches/safari-607-branch/Source/WebCore/ChangeLog	2019-03-13 08:24:26 UTC (rev 242853)
@@ -1,5 +1,35 @@
 2019-03-13  Babak Shafiei  <[email protected]>
 
+        Cherry-pick r241632. rdar://problem/48839379
+
+    Sample domainsVisited diagnostic logging
+    https://bugs.webkit.org/show_bug.cgi?id=194657
+    
+    Reviewed by Ryosuke Niwa.
+    
+    Sample domainsVisited diagnostic logging, we are getting a lot of data from
+    this key and this is hurting our other keys.
+    
+    * page/Page.cpp:
+    (WebCore::Page::logNavigation):
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@241632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2019-02-15  Chris Dumez  <[email protected]>
+
+            Sample domainsVisited diagnostic logging
+            https://bugs.webkit.org/show_bug.cgi?id=194657
+
+            Reviewed by Ryosuke Niwa.
+
+            Sample domainsVisited diagnostic logging, we are getting a lot of data from
+            this key and this is hurting our other keys.
+
+            * page/Page.cpp:
+            (WebCore::Page::logNavigation):
+
+2019-03-13  Babak Shafiei  <[email protected]>
+
         Cherry-pick r241608. rdar://problem/48839277
 
     [WebVTT] Inline WebVTT styles should start with '::cue'

Modified: branches/safari-607-branch/Source/WebCore/page/Page.cpp (242852 => 242853)


--- branches/safari-607-branch/Source/WebCore/page/Page.cpp	2019-03-13 08:24:23 UTC (rev 242852)
+++ branches/safari-607-branch/Source/WebCore/page/Page.cpp	2019-03-13 08:24:26 UTC (rev 242853)
@@ -2362,7 +2362,7 @@
     diagnosticLoggingClient().logDiagnosticMessage(DiagnosticLoggingKeys::navigationKey(), navigationDescription, ShouldSample::No);
 
     if (!navigation.domain.isEmpty())
-        diagnosticLoggingClient().logDiagnosticMessageWithEnhancedPrivacy(DiagnosticLoggingKeys::domainVisitedKey(), navigation.domain, ShouldSample::No);
+        diagnosticLoggingClient().logDiagnosticMessageWithEnhancedPrivacy(DiagnosticLoggingKeys::domainVisitedKey(), navigation.domain, ShouldSample::Yes);
 }
 
 void Page::mainFrameLoadStarted(const URL& destinationURL, FrameLoadType type)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to