Title: [242936] trunk/Source/WebCore
- Revision
- 242936
- Author
- [email protected]
- Date
- 2019-03-13 22:44:24 -0700 (Wed, 13 Mar 2019)
Log Message
Fix the argument type of RenderView::resumePausedImageAnimationsIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=195659
Reviewed by Saam Barati.
The two callers of resumePausedImageAnimationsIfNeeded() both get the IntRect
as a reference. The rect was going on the stack then used as a reference again.
* rendering/RenderView.cpp:
(WebCore::RenderView::resumePausedImageAnimationsIfNeeded):
* rendering/RenderView.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (242935 => 242936)
--- trunk/Source/WebCore/ChangeLog 2019-03-14 04:49:15 UTC (rev 242935)
+++ trunk/Source/WebCore/ChangeLog 2019-03-14 05:44:24 UTC (rev 242936)
@@ -1,3 +1,17 @@
+2019-03-13 Benjamin Poulain <[email protected]>
+
+ Fix the argument type of RenderView::resumePausedImageAnimationsIfNeeded()
+ https://bugs.webkit.org/show_bug.cgi?id=195659
+
+ Reviewed by Saam Barati.
+
+ The two callers of resumePausedImageAnimationsIfNeeded() both get the IntRect
+ as a reference. The rect was going on the stack then used as a reference again.
+
+ * rendering/RenderView.cpp:
+ (WebCore::RenderView::resumePausedImageAnimationsIfNeeded):
+ * rendering/RenderView.h:
+
2019-03-13 Zalan Bujtas <[email protected]>
[ContentChangeObserver] Stop content observation when content calls preventDefault() on touch events
Modified: trunk/Source/WebCore/rendering/RenderView.cpp (242935 => 242936)
--- trunk/Source/WebCore/rendering/RenderView.cpp 2019-03-14 04:49:15 UTC (rev 242935)
+++ trunk/Source/WebCore/rendering/RenderView.cpp 2019-03-14 05:44:24 UTC (rev 242936)
@@ -864,7 +864,7 @@
images.removeFirst(&image);
}
-void RenderView::resumePausedImageAnimationsIfNeeded(IntRect visibleRect)
+void RenderView::resumePausedImageAnimationsIfNeeded(const IntRect& visibleRect)
{
Vector<std::pair<RenderElement*, CachedImage*>, 10> toRemove;
for (auto& it : m_renderersWithPausedImageAnimation) {
Modified: trunk/Source/WebCore/rendering/RenderView.h (242935 => 242936)
--- trunk/Source/WebCore/rendering/RenderView.h 2019-03-14 04:49:15 UTC (rev 242935)
+++ trunk/Source/WebCore/rendering/RenderView.h 2019-03-14 05:44:24 UTC (rev 242936)
@@ -166,7 +166,7 @@
void updateVisibleViewportRect(const IntRect&);
void registerForVisibleInViewportCallback(RenderElement&);
void unregisterForVisibleInViewportCallback(RenderElement&);
- void resumePausedImageAnimationsIfNeeded(IntRect visibleRect);
+ void resumePausedImageAnimationsIfNeeded(const IntRect& visibleRect);
void addRendererWithPausedImageAnimations(RenderElement&, CachedImage&);
void removeRendererWithPausedImageAnimations(RenderElement&);
void removeRendererWithPausedImageAnimations(RenderElement&, CachedImage&);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
