Title: [242962] trunk/Source/WebInspectorUI
- Revision
- 242962
- Author
- [email protected]
- Date
- 2019-03-14 13:48:38 -0700 (Thu, 14 Mar 2019)
Log Message
Web Inspector: REGRESSION: Canvas: the first processed action should be selected as soon as it's available if no previous selected action exists
https://bugs.webkit.org/show_bug.cgi?id=195732
<rdar://problem/48875214>
Reviewed by Matt Baker.
* UserInterface/Views/CanvasSidebarPanel.js:
(WI.CanvasSidebarPanel.prototype._handleRecordingProcessedAction):
Rather than wait until the entire recording is ready, set the selected action as soon as the
first action is ready (assuming there isn't already a selected action).
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (242961 => 242962)
--- trunk/Source/WebInspectorUI/ChangeLog 2019-03-14 20:46:04 UTC (rev 242961)
+++ trunk/Source/WebInspectorUI/ChangeLog 2019-03-14 20:48:38 UTC (rev 242962)
@@ -1,3 +1,16 @@
+2019-03-14 Devin Rousso <[email protected]>
+
+ Web Inspector: REGRESSION: Canvas: the first processed action should be selected as soon as it's available if no previous selected action exists
+ https://bugs.webkit.org/show_bug.cgi?id=195732
+ <rdar://problem/48875214>
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Views/CanvasSidebarPanel.js:
+ (WI.CanvasSidebarPanel.prototype._handleRecordingProcessedAction):
+ Rather than wait until the entire recording is ready, set the selected action as soon as the
+ first action is ready (assuming there isn't already a selected action).
+
2019-03-14 Joseph Pecoraro <[email protected]>
Web Inspector: Network - HAR Import
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js (242961 => 242962)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js 2019-03-14 20:46:04 UTC (rev 242961)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js 2019-03-14 20:48:38 UTC (rev 242962)
@@ -577,12 +577,14 @@
console.assert(isInitialStateAction || this._recordingTreeOutline.children.lastValue instanceof WI.FolderTreeElement, "There should be a WI.FolderTreeElement for the frame for this action.");
this._createRecordingActionTreeElement(action, index, isInitialStateAction ? this._recordingTreeOutline : this._recordingTreeOutline.children.lastValue);
+ if (!this._recording[WI.CanvasSidebarPanel.SelectedActionSymbol]) {
+ console.assert(action ="" this._recording.actions[0]);
+ this.action = ""
+ }
+
if (this._recording.ready) {
this._recording.removeEventListener(null, null, this);
- if (!this._recording[WI.CanvasSidebarPanel.SelectedActionSymbol])
- this.action = ""
-
if (this._recordingProcessingOptionsContainer) {
this._recordingProcessingOptionsContainer.remove();
this._recordingProcessingOptionsContainer = null;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
