Title: [102296] trunk/Tools
- Revision
- 102296
- Author
- [email protected]
- Date
- 2011-12-07 18:09:22 -0800 (Wed, 07 Dec 2011)
Log Message
[filter-build-webkit] should not emit reset color when --no-color is given
https://bugs.webkit.org/show_bug.cgi?id=73992
Reviewed by Daniel Bates.
Stop printing control sequences when --no-color is given.
After this change, the filter runs nicely even on environments
like Emacs compilation-mode which cannot understand the control sequence.
* Scripts/filter-build-webkit:
(printLine):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (102295 => 102296)
--- trunk/Tools/ChangeLog 2011-12-08 02:09:14 UTC (rev 102295)
+++ trunk/Tools/ChangeLog 2011-12-08 02:09:22 UTC (rev 102296)
@@ -1,3 +1,17 @@
+2011-12-07 MORITA Hajime <[email protected]>
+
+ [filter-build-webkit] should not emit reset color when --no-color is given
+ https://bugs.webkit.org/show_bug.cgi?id=73992
+
+ Reviewed by Daniel Bates.
+
+ Stop printing control sequences when --no-color is given.
+ After this change, the filter runs nicely even on environments
+ like Emacs compilation-mode which cannot understand the control sequence.
+
+ * Scripts/filter-build-webkit:
+ (printLine):
+
2011-12-07 Eric Seidel <[email protected]>
Use free memory to determine if we have space for DRT instances instead of total memory
Modified: trunk/Tools/Scripts/filter-build-webkit (102295 => 102296)
--- trunk/Tools/Scripts/filter-build-webkit 2011-12-08 02:09:14 UTC (rev 102295)
+++ trunk/Tools/Scripts/filter-build-webkit 2011-12-08 02:09:22 UTC (rev 102296)
@@ -178,13 +178,15 @@
elsif ($style == STYLE_ALERT) { print OUTPUT_HANDLE "<p class=\"alert\">$line</p>"; }
else { print OUTPUT_HANDLE "<p>$line</p>"; }
} else {
- my $colors = "reset";
if ($useColor) {
+ my $colors = "reset";
if ($style == STYLE_HEADER) { $colors = "blue"; }
if ($style == STYLE_SUCCESS) { $colors = "green"; }
if ($style == STYLE_ALERT) { $colors = "red"; }
+ print OUTPUT_HANDLE possiblyColored($colors, $line);
+ } else {
+ print OUTPUT_HANDLE $line;
}
- print OUTPUT_HANDLE possiblyColored($colors, $line);
}
print OUTPUT_HANDLE "\n";
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
